Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 287133005: Make v8::TryCatch able to consume natively thrown exceptions. (Closed)

Created:
6 years, 7 months ago by Michael Starzinger
Modified:
6 years, 7 months ago
Reviewers:
haraken, Yang
CC:
v8-dev
Visibility:
Public.

Description

Make v8::TryCatch able to consume natively thrown exceptions. R=yangguo@chromium.org, haraken@chromium.org BUG=chromium:362388 TEST=cctest/test-api/TryCatchNative LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21427

Patch Set 1 #

Patch Set 2 : Make ready for review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -12 lines) Patch
M src/isolate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 4 chunks +65 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 7 months ago (2014-05-21 17:08:21 UTC) #1
Yang
On 2014/05/21 17:08:21, Michael Starzinger wrote: lgtm.
6 years, 7 months ago (2014-05-22 07:07:21 UTC) #2
Michael Starzinger
6 years, 7 months ago (2014-05-22 08:46:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698