Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2871323002: Fix flaky LayerTreeHostTestStartPageScaleAnimation test. (Closed)

Created:
3 years, 7 months ago by danakj
Modified:
3 years, 7 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, sunnyps
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky LayerTreeHostTestStartPageScaleAnimation test. The test can get a main frame before the page scale animation starts, which would be aborted. In this case the source frame number increments twice before we see the page scale animation run. R=vmpstr@chromium.org BUG=713257 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2871323002 Cr-Commit-Position: refs/heads/master@{#470731} Committed: https://chromium.googlesource.com/chromium/src/+/44afd4d12b169f43c3c0dade63486a4541bcc147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
danakj
3 years, 7 months ago (2017-05-10 19:57:32 UTC) #2
vmpstr
lgtm, thanks
3 years, 7 months ago (2017-05-10 22:05:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871323002/1
3 years, 7 months ago (2017-05-10 22:07:43 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 22:27:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44afd4d12b169f43c3c0dade6348...

Powered by Google App Engine
This is Rietveld 408576698