Add histogram for Blink's spell check request interval

Add histogram for Blink's spell check request interval

This patch adds a histogram for Blink's spell check request interval,
so that we can understand how aggressive Blink's spellchecker is, and
decide if any optimization is needed.

BUG=721490
Review-Url: https://codereview.chromium.org/2871313002
Cr-Commit-Position: refs/heads/master@{#471466}
Committed: https://chromium.googlesource.com/chromium/src/+/6ddb331240ae137b7e74ec611fd7caa4114fdea4

[Xiaocheng, 2017-05-10 19:34:37]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 19:35:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:42:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:42:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2017-05-11 18:21:59]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 18:22:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-11 18:58:46]

Description was changed from

==========
Add histogram for Blink's spell check request interval

BUG=
==========

to

==========
Add histogram for Blink's spell check request interval

BUG=721490
==========

[Xiaocheng, 2017-05-11 18:59:50]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-11 18:59:50]

Is this what we want?

I agree there will be a lot of noise, but haven't found a way to reduce it in
the impl in an effective and clean way... Maybe we just manually cut the min and
max extremes from the test result?

[commit-bot: I haz the power, 2017-05-11 20:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 20:42:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-05-12 04:32:45]

On 2017/05/11 at 18:59:50, xiaochengh wrote:
> Is this what we want?
Yes.

> I agree there will be a lot of noise, but haven't found a way to reduce it in
the impl in an effective and clean way... Maybe we just manually cut the min and
max extremes from the test result?
Yes, this method makes some noise, but I guess we can easily exclude them,
interval > 1s.
Small intervals may not be noise. Many small intervals means we check spelling
too aggressive.

[yosin_UTC9, 2017-05-12 04:33:34]

lgtm w/ nit

Please choose reviewer for histograms.xml

https://codereview.chromium.org/2871313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
(right):

https://codereview.chromium.org/2871313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp:162:
double current_request_time = MonotonicallyIncreasingTime();
nit: s/double/const double/

https://codereview.chromium.org/2871313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp:164:
double interval_ms = (current_request_time - last_request_time_) * 1000.0;
nit: s/double/const double/

[Xiaocheng, 2017-05-12 18:32:51]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[Xiaocheng, 2017-05-12 18:34:42]

Description was changed from

==========
Add histogram for Blink's spell check request interval

BUG=721490
==========

to

==========
Add histogram for Blink's spell check request interval

This patch adds a histogram for Blink's spell check request interval,
so that we can understand how aggressive Blink's spellchecker is, and
decide if any optimization is needed.

BUG=721490
==========

[commit-bot: I haz the power, 2017-05-12 18:35:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-12 18:35:12]

xiaochengh@chromium.org changed reviewers:
+ isherman@chromium.org

[Xiaocheng, 2017-05-12 18:35:15]

+isherman

Thanks for the review. Updated.

https://codereview.chromium.org/2871313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
(right):

https://codereview.chromium.org/2871313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp:162:
double current_request_time = MonotonicallyIncreasingTime();
On 2017/05/12 at 04:33:34, yosin_UTC9 wrote:
> nit: s/double/const double/

Done.

https://codereview.chromium.org/2871313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp:164:
double interval_ms = (current_request_time - last_request_time_) * 1000.0;
On 2017/05/12 at 04:33:34, yosin_UTC9 wrote:
> nit: s/double/const double/

Done.

[commit-bot: I haz the power, 2017-05-12 20:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 20:04:02]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ilya Sherman, 2017-05-12 21:02:43]

metrics lgtm

[Xiaocheng, 2017-05-12 21:05:33]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-05-12 21:05:34]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2871313002/#ps20001
(title: "Fri May 12 11:31:33 PDT 2017")

[Xiaocheng, 2017-05-12 21:05:46]

Thanks for the review!

[commit-bot: I haz the power, 2017-05-12 21:06:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 22:24:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494623133944400,
"parent_rev": "b0fbfe1542e538079f74439a578a2b08cb8a88ba", "commit_rev":
"6ddb331240ae137b7e74ec611fd7caa4114fdea4"}

[commit-bot: I haz the power, 2017-05-12 22:25:04]

Description was changed from

==========
Add histogram for Blink's spell check request interval

This patch adds a histogram for Blink's spell check request interval,
so that we can understand how aggressive Blink's spellchecker is, and
decide if any optimization is needed.

BUG=721490
==========

to

==========
Add histogram for Blink's spell check request interval

This patch adds a histogram for Blink's spell check request interval,
so that we can understand how aggressive Blink's spellchecker is, and
decide if any optimization is needed.

BUG=721490

Review-Url: https://codereview.chromium.org/2871313002
Cr-Commit-Position: refs/heads/master@{#471466}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ddb331240ae137b7e74ec611fd7...
==========

[commit-bot: I haz the power, 2017-05-12 22:25:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ddb331240ae137b7e74ec611fd7...