Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2871303004: Rename TaskRunner::RunsTasksOnCurrentThread() in //chrome (Closed)

Created:
3 years, 7 months ago by Yeol Park
Modified:
3 years, 7 months ago
CC:
achuith+watch_chromium.org, agrieve+watch_chromium.org, alemate+watch_chromium.org, avayvod+watch_chromium.org, awdf+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, derat+watch_chromium.org, dominickn+watch_chromium.org, David Trainor- moved to gerrit, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, imcheng+watch_chromium.org, ios-reviews_chromium.org, isheriff+watch_chromium.org, jasonroberts+watch_google.com, jshin+watch_chromium.org, kinuko+fileapi, markusheintz_, mfoltz+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-notifications_chromium.org, msramek+watch_chromium.org, nhiroki, oshima+watch_chromium.org, Peter Beverloo, pkotwicz+watch_chromium.org, Lei Zhang, timvolodine, tommycli, tzik, vakh+watch_chromium.org, xjz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename TaskRunner::RunsTasksOnCurrentThread() in //chrome renamed TaskRunner::RunsTasksOnCurrentThread() to TaskRunner::RunsTasksInCurrentSequence() in //chrome BUG=665062 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2871303004 Cr-Commit-Position: refs/heads/master@{#472283} Committed: https://chromium.googlesource.com/chromium/src/+/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase & update comment #

Patch Set 3 : fixed build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -255 lines) Patch
M chrome/browser/after_startup_task_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_media_license_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/media_licenses_counter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_data.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_data_base.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_icon_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_store.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings_impl_x11.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/conflicts/module_database_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_data_migrator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/image_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 1 2 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/policy/cloud/test_request_interceptor.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/printing/print_job_worker_owner.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_job_worker_owner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/printer_query.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 1 2 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 26 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 17 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 16 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 32 chunks +51 lines, -51 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/local/root_delete_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/win/chrome_select_file_dialog_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/win/settings_app_monitor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 37 (32 generated)
Yeol Park
PTAL :) jochen@, sky@ for //chrome/browser/* dpapad@, thestig@ for //chrome/browser/printing/*
3 years, 7 months ago (2017-05-12 08:34:37 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-15 05:31:37 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/2871303004/diff/1/chrome/browser/printing/print_job_worker_owner.h File chrome/browser/printing/print_job_worker_owner.h (right): https://codereview.chromium.org/2871303004/diff/1/chrome/browser/printing/print_job_worker_owner.h#newcode47 chrome/browser/printing/print_job_worker_owner.h:47: // Returns true if the current thread is ...
3 years, 7 months ago (2017-05-15 18:16:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871303004/40001
3 years, 7 months ago (2017-05-17 01:48:21 UTC) #34
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 02:00:08 UTC) #37
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/be58808056df4a76ea7ae3b6831b...

Powered by Google App Engine
This is Rietveld 408576698