Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2871273002: 📰 Record the first scroll event on the recycler view (Closed)

Created:
3 years, 7 months ago by dgn
Modified:
3 years, 7 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org, finkm
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Record the first scroll event on the recycler view BUG=693593 Review-Url: https://codereview.chromium.org/2871273002 Cr-Commit-Position: refs/heads/master@{#471265} Committed: https://chromium.googlesource.com/chromium/src/+/36cc3da5e8b2360e246342351ee0959fb9e7ffea

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetrics.java View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java View 3 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgn
bauerb, asvitkine: PTAL finkm: FYI
3 years, 7 months ago (2017-05-11 17:21:04 UTC) #2
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-11 19:30:19 UTC) #7
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-12 09:39:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871273002/20001
3 years, 7 months ago (2017-05-12 10:06:52 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 10:16:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/36cc3da5e8b2360e246342351ee0...

Powered by Google App Engine
This is Rietveld 408576698