Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2871263003: Set |config_| only after decoder has been successfully configured (Closed)

Created:
3 years, 7 months ago by Chandan
Modified:
3 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set |config_| only after decoder has been successfully configured This CL sets |config_| only if ConfigureDecoder(..) returns true. BUG=None Review-Url: https://codereview.chromium.org/2871263003 Cr-Commit-Position: refs/heads/master@{#471680} Committed: https://chromium.googlesource.com/chromium/src/+/e2586f347ccc9738756436fd567fd842069e2bf5

Patch Set 1 #

Patch Set 2 : fixed unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -33 lines) Patch
M media/filters/ffmpeg_audio_decoder.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 6 chunks +18 lines, -19 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Chandan
PTAL. Thank you.
3 years, 7 months ago (2017-05-11 16:07:24 UTC) #10
xhwang
lgtm
3 years, 7 months ago (2017-05-15 03:26:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871263003/20001
3 years, 7 months ago (2017-05-15 04:34:32 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 06:17:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e2586f347ccc9738756436fd567f...

Powered by Google App Engine
This is Rietveld 408576698