Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2871253002: Chrome OS: Fix the chopped Wi-Fi Network Configuration Dialog (Closed)

Created:
3 years, 7 months ago by xdai1
Modified:
3 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS: Fix the chopped Wi-Fi Network Configuration Dialog BUG=717946 Review-Url: https://codereview.chromium.org/2871253002 Cr-Commit-Position: refs/heads/master@{#470644} Committed: https://chromium.googlesource.com/chromium/src/+/5163e3b4833463b8e30df21b91a527f7c7297baa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
xdai1
stevenjb@, could you help review this CL please? Thanks!
3 years, 7 months ago (2017-05-10 16:56:10 UTC) #2
stevenjb
I modified the subject (the config dialog is also available from the system menu). Thanks ...
3 years, 7 months ago (2017-05-10 17:05:57 UTC) #6
xdai1
On 2017/05/10 17:05:57, stevenjb wrote: > I modified the subject (the config dialog is also ...
3 years, 7 months ago (2017-05-10 17:58:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871253002/1
3 years, 7 months ago (2017-05-10 17:59:30 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 18:13:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5163e3b4833463b8e30df21b91a5...

Powered by Google App Engine
This is Rietveld 408576698