Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2871243003: Enable new-virtual-keyboard-behavior flag by default. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2928 matching lines...) Expand 10 before | Expand all | Expand 10 after
2939 flag_descriptions::kOneGoogleBarOnLocalNtpDescription, kOsDesktop, 2939 flag_descriptions::kOneGoogleBarOnLocalNtpDescription, kOsDesktop,
2940 FEATURE_VALUE_TYPE(features::kOneGoogleBarOnLocalNtp)}, 2940 FEATURE_VALUE_TYPE(features::kOneGoogleBarOnLocalNtp)},
2941 #endif // !defined(OS_ANDROID) && !defined(OS_IOS) 2941 #endif // !defined(OS_ANDROID) && !defined(OS_IOS)
2942 2942
2943 #if defined(OS_MACOSX) 2943 #if defined(OS_MACOSX)
2944 {"mac-rtl", flag_descriptions::kMacRTLName, 2944 {"mac-rtl", flag_descriptions::kMacRTLName,
2945 flag_descriptions::kMacRTLDescription, kOsMac, 2945 flag_descriptions::kMacRTLDescription, kOsMac,
2946 FEATURE_VALUE_TYPE(features::kMacRTL)}, 2946 FEATURE_VALUE_TYPE(features::kMacRTL)},
2947 #endif // defined(OS_MACOSX) 2947 #endif // defined(OS_MACOSX)
2948 2948
2949 #if defined(OS_CHROMEOS)
2950 {"disable-new-virtual-keyboard-behavior",
2951 flag_descriptions::kDisableNewVirtualKeyboardBehaviorName,
2952 flag_descriptions::kDisableNewVirtualKeyboardBehaviorDescription, kOsCrOS,
2953 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableNewVirtualKeyboardBehavior)},
2954 #endif // defined(OS_CHROMEOS)
2955
2949 // NOTE: Adding new command-line switches requires adding corresponding 2956 // NOTE: Adding new command-line switches requires adding corresponding
2950 // entries to enum "LoginCustomFlags" in histograms/enums.xml. See note in 2957 // entries to enum "LoginCustomFlags" in histograms/enums.xml. See note in
2951 // enums.xml and don't forget to run AboutFlagsHistogramTest unit test. 2958 // enums.xml and don't forget to run AboutFlagsHistogramTest unit test.
2952 }; 2959 };
2953 2960
2954 class FlagsStateSingleton { 2961 class FlagsStateSingleton {
2955 public: 2962 public:
2956 FlagsStateSingleton() 2963 FlagsStateSingleton()
2957 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2964 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2958 ~FlagsStateSingleton() {} 2965 ~FlagsStateSingleton() {}
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
3164 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3171 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3165 3172
3166 const FeatureEntry* GetFeatureEntries(size_t* count) { 3173 const FeatureEntry* GetFeatureEntries(size_t* count) {
3167 *count = arraysize(kFeatureEntries); 3174 *count = arraysize(kFeatureEntries);
3168 return kFeatureEntries; 3175 return kFeatureEntries;
3169 } 3176 }
3170 3177
3171 } // namespace testing 3178 } // namespace testing
3172 3179
3173 } // namespace about_flags 3180 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698