Enable new-virtual-keyboard-behavior flag by default.

Enable new-virtual-keyboard-behavior flag by default.

This CL introduces a new flag to let users revert it easier.

BUG=624521
TEST=The added flag shows up in chrome://flags.

Review-Url: https://codereview.chromium.org/2871243003
Cr-Commit-Position: refs/heads/master@{#472711}
Committed: https://chromium.googlesource.com/chromium/src/+/c5bff5bfdf04b0831f7ba4a976e8e5401523bd85

[yhanada, 2017-05-11 01:40:02]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 01:40:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:11:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhanada, 2017-05-11 04:32:40]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 04:34:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 05:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 05:51:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhanada, 2017-05-11 07:51:17]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 07:51:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 09:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 09:42:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhanada, 2017-05-15 08:18:44]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 08:19:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-05-15 08:36:25]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 08:36:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 10:25:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 10:25:44]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-05-16 08:37:18]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 08:37:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 10:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 10:14:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhanada, 2017-05-16 10:49:59]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 10:50:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-05-16 11:37:09]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 11:37:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 12:05:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 12:05:26]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[yhanada, 2017-05-16 12:25:31]

yhanada@chromium.org changed reviewers:
+ oshima@chromium.org, sky@chromium.org

[yhanada, 2017-05-16 12:25:32]

PTAL. Thanks!

[oshima, 2017-05-16 12:31:30]

lgtm with nits

https://codereview.chromium.org/2871243003/diff/120001/ash/shelf/shelf_layout...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2871243003/diff/120001/ash/shelf/shelf_layout...
ash/shelf/shelf_layout_manager_unittest.cc:1837: DisableNewVKMode();
you can just add a flag here.

https://codereview.chromium.org/2871243003/diff/120001/ash/wm/workspace/works...
File ash/wm/workspace/workspace_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2871243003/diff/120001/ash/wm/workspace/works...
ash/wm/workspace/workspace_layout_manager_unittest.cc:108: if
(!command_line->HasSwitch(::switches::kDisableNewVirtualKeyboardBehavior))
you can just add it

[yhanada, 2017-05-17 01:33:37]

https://codereview.chromium.org/2871243003/diff/120001/ash/shelf/shelf_layout...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2871243003/diff/120001/ash/shelf/shelf_layout...
ash/shelf/shelf_layout_manager_unittest.cc:1837: DisableNewVKMode();
On 2017/05/16 12:31:30, oshima wrote:
> you can just add a flag here.

Done.

https://codereview.chromium.org/2871243003/diff/120001/ash/wm/workspace/works...
File ash/wm/workspace/workspace_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2871243003/diff/120001/ash/wm/workspace/works...
ash/wm/workspace/workspace_layout_manager_unittest.cc:108: if
(!command_line->HasSwitch(::switches::kDisableNewVirtualKeyboardBehavior))
On 2017/05/16 12:31:30, oshima wrote:
> you can just add it

Done.

[yhanada, 2017-05-17 01:33:42]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 01:35:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:37:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:37:22]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-17 18:07:25]

LGTM

https://codereview.chromium.org/2871243003/diff/140001/ui/base/ui_base_switch...
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/2871243003/diff/140001/ui/base/ui_base_switch...
ui/base/ui_base_switches.h:41: UI_BASE_EXPORT extern const char
kDisableNewVirtualKeyboardBehavior[];
Keep sorted please.

[yhanada, 2017-05-18 01:59:35]

Thank you for reviewing.

https://codereview.chromium.org/2871243003/diff/140001/ui/base/ui_base_switch...
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/2871243003/diff/140001/ui/base/ui_base_switch...
ui/base/ui_base_switches.h:41: UI_BASE_EXPORT extern const char
kDisableNewVirtualKeyboardBehavior[];
On 2017/05/17 18:07:25, sky wrote:
> Keep sorted please.

Done.

[yhanada, 2017-05-18 01:59:43]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-05-18 01:59:44]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2871243003/#ps160001
(title: "keep sorted the declarations")

[commit-bot: I haz the power, 2017-05-18 02:04:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:41:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhanada, 2017-05-18 03:53:46]

The CQ bit was checked by yhanada@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:55:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 06:37:18]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1495079626296230,
"parent_rev": "a872e99f20ad4d94d954241b6583aa98a46ee4de", "commit_rev":
"c5bff5bfdf04b0831f7ba4a976e8e5401523bd85"}

[commit-bot: I haz the power, 2017-05-18 06:37:31]

Description was changed from

==========
Enable new-virtual-keyboard-behavior flag by default.

This CL introduces a new flag to let users revert it easier.

BUG=624521
TEST=The added flag shows up in chrome://flags.
==========

to

==========
Enable new-virtual-keyboard-behavior flag by default.

This CL introduces a new flag to let users revert it easier.

BUG=624521
TEST=The added flag shows up in chrome://flags.

Review-Url: https://codereview.chromium.org/2871243003
Cr-Commit-Position: refs/heads/master@{#472711}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5bff5bfdf04b0831f7ba4a976e8...
==========

[commit-bot: I haz the power, 2017-05-18 06:37:32]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/c5bff5bfdf04b0831f7ba4a976e8...