Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tabs/tab_strip_model.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc
index 098d89d303ad3d9cef7e7662ddbaec5f78829b3b..7c8c687b602bdcdb505f88452ed8eee5c6f269bb 100644
--- a/chrome/browser/ui/tabs/tab_strip_model.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model.cc
@@ -315,6 +315,10 @@ void TabStripModel::InsertWebContentsAt(int index,
data->set_opener(active_contents);
}
+ // TODO(gbillock): Needs update to PopupManager. Should probably have a method
+ // there about blocking web contents, or move all blocking mgmt to the
+ // PopupManager instead of here at all.
+
web_modal::WebContentsModalDialogManager* modal_dialog_manager =
web_modal::WebContentsModalDialogManager::FromWebContents(contents);
if (modal_dialog_manager)

Powered by Google App Engine
This is Rietveld 408576698