chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc - Issue 287123002: [WebModals] New API for browser-scoped popup management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

Issue 287123002: [WebModals] New API for browser-scoped popup management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

diff --git a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

index 1b9d752eeb5974aa5dd5dd2dd04f6ae7f2e298e1..ccba78c2b2bb0b11b93292f25a4d10e37f0e47e7 100644

--- a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

+++ b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

@@ -61,6 +61,13 @@ bool ChromeWebContentsViewDelegateViews::Focus() {

}

+ // TODO(gbillock): Replace this stanza to talk to the PopupManager:

+ // Browser* b = FindBrowserWithWebContents(web_contents_);

+ // if (b)

+ // b->popup_manager()->FocusTopmostPopupForWebContentsIfActive(

+ // web_contents_);

WebContentsModalDialogManager* web_contents_modal_dialog_manager =

WebContentsModalDialogManager::FromWebContents(web_contents_);

if (web_contents_modal_dialog_manager) {

« no previous file with comments | « chrome/browser/ui/tabs/tab_strip_model.cc ('k') | components/components_tests.gyp » ('j') | components/web_modal/popup_manager.cc » ('J')