Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2871183002: Use emplace_back in RTree::Build (Closed)

Created:
3 years, 7 months ago by dbatyai
Modified:
3 years, 7 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use emplace_back in RTree::Build By using emplace_back istead os push_back we don't have to copy the elements into the vector. | Test | Before (runs/s) | After (runs/s) | | rtree_construct: 100= | 40609.00390625 | 45958.69140625 | | rtree_construct: 1000= | 4720.29833984375 | 5390.62841796875 | | rtree_construct: 10000= | 456.375244140625 | 516.6461791992188 | | rtree_construct: 100000= | 45.47178268432617 | 51.81435012817383 | CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2871183002 Cr-Commit-Position: refs/heads/master@{#470909} Committed: https://chromium.googlesource.com/chromium/src/+/3dc8481c601fd89ae33a6defededf5875f5ba65e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/rtree.h View 2 chunks +7 lines, -4 lines 0 comments Download
M cc/base/rtree.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
vmpstr
lgtm, thanks
3 years, 7 months ago (2017-05-10 18:03:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871183002/1
3 years, 7 months ago (2017-05-11 09:26:30 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 10:47:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3dc8481c601fd89ae33a6defeded...

Powered by Google App Engine
This is Rietveld 408576698