Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2871173007: Whitelist voice_icon_keyboard_accessory as not found image (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), jif
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist voice_icon_keyboard_accessory as not found image voice_icon_keyboard_accessory is not available upstream but it is used in the code. This CL adds it as an exception. BUG=721338 Review-Url: https://codereview.chromium.org/2871173007 Cr-Commit-Position: refs/heads/master@{#470936} Committed: https://chromium.googlesource.com/chromium/src/+/91763e4b9dcc698868d3140d83db15e3a59498f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/app/startup/setup_debugging.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
gambard
sdefresne: PTAL.
3 years, 7 months ago (2017-05-11 12:50:01 UTC) #2
sdefresne
lgtm
3 years, 7 months ago (2017-05-11 12:51:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871173007/1
3 years, 7 months ago (2017-05-11 12:53:11 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 13:08:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91763e4b9dcc698868d3140d83db...

Powered by Google App Engine
This is Rietveld 408576698