Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2871173006: [heap] Add a flag to disable remembered set verification. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add a flag to disable remembered set verification. BUG=chromium:720606 Review-Url: https://codereview.chromium.org/2871173006 Cr-Commit-Position: refs/heads/master@{#45252} Committed: https://chromium.googlesource.com/v8/v8/+/e4b3f93eab8414d9c121a8740d3c91834e7449d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ulan
ptal
3 years, 7 months ago (2017-05-11 10:10:55 UTC) #2
Michael Achenbach
lgtm
3 years, 7 months ago (2017-05-11 10:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871173006/1
3 years, 7 months ago (2017-05-11 10:29:50 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 11:04:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e4b3f93eab8414d9c121a8740d3c91834e7...

Powered by Google App Engine
This is Rietveld 408576698