Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2871173005: [Payments] Remove extra line in shipping labels (Closed)

Created:
3 years, 7 months ago by Mathieu
Modified:
3 years, 7 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Remove extra line in shipping labels We were sometimes adding an empty line at the end of labels. BUG=None TEST=visual Review-Url: https://codereview.chromium.org/2871173005 Cr-Commit-Position: refs/heads/master@{#470964} Committed: https://chromium.googlesource.com/chromium/src/+/87b94a268636d3faedf6f0b530072f8002c1d1ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mathieu
Anthony, PTAL!
3 years, 7 months ago (2017-05-11 01:48:35 UTC) #2
anthonyvd
lgtm
3 years, 7 months ago (2017-05-11 12:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871173005/1
3 years, 7 months ago (2017-05-11 12:50:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451696)
3 years, 7 months ago (2017-05-11 14:29:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871173005/1
3 years, 7 months ago (2017-05-11 14:48:33 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 15:29:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/87b94a268636d3faedf6f0b53007...

Powered by Google App Engine
This is Rietveld 408576698