Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/test/data/webui/settings/basic_page_browsertest.js

Issue 2871173004: WebUI cleanup: Remove unnecessary *_SANITIZER related ifdefs from tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/data/webui/settings/advanced_page_browsertest.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for the Settings basic page. */ 5 /** @fileoverview Suite of tests for the Settings basic page. */
6 6
7 GEN_INCLUDE(['settings_page_browsertest.js']); 7 GEN_INCLUDE(['settings_page_browsertest.js']);
8 8
9 /** 9 /**
10 * @constructor 10 * @constructor
11 * @extends {SettingsPageBrowserTest} 11 * @extends {SettingsPageBrowserTest}
12 */ 12 */
13 function SettingsBasicPageBrowserTest() {} 13 function SettingsBasicPageBrowserTest() {}
14 14
15 SettingsBasicPageBrowserTest.prototype = { 15 SettingsBasicPageBrowserTest.prototype = {
16 __proto__: SettingsPageBrowserTest.prototype, 16 __proto__: SettingsPageBrowserTest.prototype,
17 17
18 /** @override */ 18 /** @override */
19 extraLibraries: SettingsPageBrowserTest.prototype.extraLibraries.concat([ 19 extraLibraries: SettingsPageBrowserTest.prototype.extraLibraries.concat([
20 'test_browser_proxy.js', 20 'test_browser_proxy.js',
21 ]), 21 ]),
22 }; 22 };
23 23
24 // Times out on debug builders and may time out on memory bots because 24 // Times out on debug builders because the Settings page can take several
25 // the Settings page can take several seconds to load in a Release build 25 // seconds to load in a Release build and several times that in a Debug build.
26 // and several times that in a Debug build. See https://crbug.com/558434. 26 // See https://crbug.com/558434.
27 GEN('#if defined(MEMORY_SANITIZER) || !defined(NDEBUG)'); 27 GEN('#if !defined(NDEBUG)');
28 GEN('#define MAYBE_Load DISABLED_Load'); 28 GEN('#define MAYBE_Load DISABLED_Load');
29 GEN('#else'); 29 GEN('#else');
30 GEN('#define MAYBE_Load Load'); 30 GEN('#define MAYBE_Load Load');
31 GEN('#endif'); 31 GEN('#endif');
32 32
33 TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() { 33 TEST_F('SettingsBasicPageBrowserTest', 'MAYBE_Load', function() {
34 // Assign |self| to |this| instead of binding since 'this' in suite() 34 // Assign |self| to |this| instead of binding since 'this' in suite()
35 // and test() will be a Mocha 'Suite' or 'Test' instance. 35 // and test() will be a Mocha 'Suite' or 'Test' instance.
36 var self = this; 36 var self = this;
37 37
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 assertNotEquals(0, page.scroller.scrollTop); 173 assertNotEquals(0, page.scroller.scrollTop);
174 174
175 settings.navigateTo(settings.Route.ABOUT); 175 settings.navigateTo(settings.Route.ABOUT);
176 assertEquals(0, page.scroller.scrollTop); 176 assertEquals(0, page.scroller.scrollTop);
177 }); 177 });
178 }); 178 });
179 179
180 // Run all registered tests. 180 // Run all registered tests.
181 mocha.run(); 181 mocha.run();
182 }); 182 });
OLDNEW
« no previous file with comments | « chrome/test/data/webui/settings/advanced_page_browsertest.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698