Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2871173004: WebUI cleanup: Remove unnecessary *_SANITIZER related ifdefs from tests. (Closed)

Created:
3 years, 7 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI cleanup: Remove unnecessary *_SANITIZER related ifdefs from tests. AS of crrev.com/2865723002, all WebUI tests are disabled on such bots. BUG=579666 Review-Url: https://codereview.chromium.org/2871173004 Cr-Commit-Position: refs/heads/master@{#470811} Committed: https://chromium.googlesource.com/chromium/src/+/9bda997770f9191507bcfcffdb1f32255b613706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M chrome/test/data/webui/md_history/md_history_browsertest.js View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/data/webui/sandboxstatus_browsertest.js View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/advanced_page_browsertest.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/basic_page_browsertest.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dpapad
3 years, 7 months ago (2017-05-10 23:22:21 UTC) #4
Dan Beam
lgtm
3 years, 7 months ago (2017-05-10 23:32:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871173004/1
3 years, 7 months ago (2017-05-11 02:13:13 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 04:49:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9bda997770f9191507bcfcffdb1f...

Powered by Google App Engine
This is Rietveld 408576698