Add LazyLineBreakIterator::Next/PreviousBreakOpportunity()

Add LazyLineBreakIterator::Next/PreviousBreakOpportunity()

This patch adds LazyLineBreakIterator::Next/PreviousBreakOpportunity(),
ported from ShapingLineBreaker. This allows iterations over break
opportunities without iterating all characters.

In addition:
1. Add LineBreakType to LazyLineBreakIterator. Most existing uses pass
   LineBreakType explicitly and they are not affected.
2. IsBreakable() and its sub functions are marked as const. All what it
   changes are cached values that mutable is reasonable.

Review-Url: https://codereview.chromium.org/2871173002
Cr-Commit-Position: refs/heads/master@{#470819}
Committed: https://chromium.googlesource.com/chromium/src/+/ba945d41f5c4ebbb6512810a7e3ec728d22cd185

[kojii, 2017-05-10 11:34:57]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 11:35:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-10 11:37:00]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-05-10 11:37:16]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-10 11:37:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 13:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 13:13:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-10 14:57:55]

Description was changed from

==========
lb

BUG=
==========

to

==========
Add LazyLineBreakIterator::Next/PreviousBreakOpportunity()

This patch adds LazyLineBreakIterator::Next/PreviousBreakOpportunity(),
ported from ShapingLineBreaker. This allows iterations over break
opportunities without iterating all characters.

In addition:
1. Add LineBreakType to LazyLineBreakIterator. Most existing uses pass
   LineBreakType explicitly and they are not affected.
2. IsBreakable() and its sub functions are marked as const. All what it
   changes are cached values that mutable is reasonable.
==========

[kojii, 2017-05-10 14:58:44]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-05-10 14:58:45]

PTAL. Is this reasonable thing to do?

[eae, 2017-05-10 16:07:48]

LGTM

Thank you!

[eae, 2017-05-10 16:09:03]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-05-10 16:10:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:54:01]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-10 18:25:06]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-10 18:27:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:46:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-11 01:12:30]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-11 01:13:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 04:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:10:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-11 04:11:20]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:12:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 05:22:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494475880487890,
"parent_rev": "a971d0c02ac324c9a11135422cba928a30840c30", "commit_rev":
"ba945d41f5c4ebbb6512810a7e3ec728d22cd185"}

[commit-bot: I haz the power, 2017-05-11 05:22:39]

Description was changed from

==========
Add LazyLineBreakIterator::Next/PreviousBreakOpportunity()

This patch adds LazyLineBreakIterator::Next/PreviousBreakOpportunity(),
ported from ShapingLineBreaker. This allows iterations over break
opportunities without iterating all characters.

In addition:
1. Add LineBreakType to LazyLineBreakIterator. Most existing uses pass
   LineBreakType explicitly and they are not affected.
2. IsBreakable() and its sub functions are marked as const. All what it
   changes are cached values that mutable is reasonable.
==========

to

==========
Add LazyLineBreakIterator::Next/PreviousBreakOpportunity()

This patch adds LazyLineBreakIterator::Next/PreviousBreakOpportunity(),
ported from ShapingLineBreaker. This allows iterations over break
opportunities without iterating all characters.

In addition:
1. Add LineBreakType to LazyLineBreakIterator. Most existing uses pass
   LineBreakType explicitly and they are not affected.
2. IsBreakable() and its sub functions are marked as const. All what it
   changes are cached values that mutable is reasonable.

Review-Url: https://codereview.chromium.org/2871173002
Cr-Commit-Position: refs/heads/master@{#470819}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba945d41f5c4ebbb6512810a7e3e...
==========

[commit-bot: I haz the power, 2017-05-11 05:22:41]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba945d41f5c4ebbb6512810a7e3e...