diagnose_bloat.py: swap --silent with --verbose.

diagnose_bloat.py: swap --silent with --verbose.

Suppress build output by default as it makes the output harder to
follow.

Other updates:
  * Remove old references to diagnose_apk_bloat.py
  * Update Linux --cloud error message
  * Fix divide-by-zero in libsupersize/describe.py

BUG=695182, 720624
Review-Url: https://codereview.chromium.org/2871143004
Cr-Commit-Position: refs/heads/master@{#470747}
Committed: https://chromium.googlesource.com/chromium/src/+/18e1d8f1798041d5df7aaeaf50065fe93367ecc7

[estevenson, 2017-05-10 20:02:07]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-05-10 20:02:08]

ptal Andrew.

Linux --cloud output isn't so useful; might even be worth excluding the --cloud
option from Linux for now, wdyt?

Index, Running Total, Section@Address, PSS
------------------------------------------------------------
+ 0)     474336 (1308.7%) d@0x7104050  474336  /tmp/lto-llvm-ac6b26.o
               .L__unnamed_729
- 1)          0 (0.0%)  d@0x7104050  -474336 /tmp/lto-llvm-536ab2.o
               .L__unnamed_729
+ 2)     296712 (818.7%) d@0x707f550  296712  /tmp/lto-llvm-ac6b26.o
               .L__unnamed_589
- 3)          8 (0.0%)  d@0x707f550  -296704 /tmp/lto-llvm-536ab2.o
               .L__unnamed_589
+ 4)     201256 (555.3%) d@0x6f559a0  201248  /tmp/lto-llvm-ac6b26.o
               .L__unnamed_503
- 5)         16 (0.0%)  d@0x6f559a0  -201240 /tmp/lto-llvm-536ab2.o
               .L__unnamed_503
+ 6)     191912 (529.5%) d@0x6fc3b40  191896  /tmp/lto-llvm-ac6b26.o
               .L__unnamed_223
- 7)         24 (0.1%)  d@0x6fc3b40  -191888 /tmp/lto-llvm-536ab2.o
               .L__unnamed_223

[agrieve, 2017-05-10 20:37:11]

On 2017/05/10 20:02:08, estevenson wrote:
> ptal Andrew.
> 
> Linux --cloud output isn't so useful; might even be worth excluding the
--cloud
> option from Linux for now, wdyt?
> 
> Index, Running Total, Section@Address, PSS
> ------------------------------------------------------------
> + 0)     474336 (1308.7%) d@0x7104050  474336  /tmp/lto-llvm-ac6b26.o
>                .L__unnamed_729
> - 1)          0 (0.0%)  d@0x7104050  -474336 /tmp/lto-llvm-536ab2.o
>                .L__unnamed_729
> + 2)     296712 (818.7%) d@0x707f550  296712  /tmp/lto-llvm-ac6b26.o
>                .L__unnamed_589
> - 3)          8 (0.0%)  d@0x707f550  -296704 /tmp/lto-llvm-536ab2.o
>                .L__unnamed_589
> + 4)     201256 (555.3%) d@0x6f559a0  201248  /tmp/lto-llvm-ac6b26.o
>                .L__unnamed_503
> - 5)         16 (0.0%)  d@0x6f559a0  -201240 /tmp/lto-llvm-536ab2.o
>                .L__unnamed_503
> + 6)     191912 (529.5%) d@0x6fc3b40  191896  /tmp/lto-llvm-ac6b26.o
>                .L__unnamed_223
> - 7)         24 (0.1%)  d@0x6fc3b40  -191888 /tmp/lto-llvm-536ab2.o
>                .L__unnamed_223

I don't think I'd remove it, but if you've found local builds give better
results, then might be worth added a log message to that effect.

lgtm

[estevenson, 2017-05-10 21:13:44]

Description was changed from

==========
diagnose_bloat.py: swap --silent with --verbose.

Suppress build output by default as it makes the output harder to
follow.

Other updates:
  * Remove old references to diagnose_apk_bloat.py
  * Update Linux --cloud error message
  * Fix divide-by-zero in libsupersize/describe.py

BUG=695182
==========

to

==========
diagnose_bloat.py: swap --silent with --verbose.

Suppress build output by default as it makes the output harder to
follow.

Other updates:
  * Remove old references to diagnose_apk_bloat.py
  * Update Linux --cloud error message
  * Fix divide-by-zero in libsupersize/describe.py

BUG=695182, 720624
==========

[estevenson, 2017-05-10 22:31:01]

On 2017/05/10 20:37:11, agrieve wrote:
> On 2017/05/10 20:02:08, estevenson wrote:
> > ptal Andrew.
> > 
> > Linux --cloud output isn't so useful; might even be worth excluding the
> --cloud
> > option from Linux for now, wdyt?
> > 
> > Index, Running Total, Section@Address, PSS
> > ------------------------------------------------------------
> > + 0)     474336 (1308.7%) d@0x7104050  474336  /tmp/lto-llvm-ac6b26.o
> >                .L__unnamed_729
> > - 1)          0 (0.0%)  d@0x7104050  -474336 /tmp/lto-llvm-536ab2.o
> >                .L__unnamed_729
> > + 2)     296712 (818.7%) d@0x707f550  296712  /tmp/lto-llvm-ac6b26.o
> >                .L__unnamed_589
> > - 3)          8 (0.0%)  d@0x707f550  -296704 /tmp/lto-llvm-536ab2.o
> >                .L__unnamed_589
> > + 4)     201256 (555.3%) d@0x6f559a0  201248  /tmp/lto-llvm-ac6b26.o
> >                .L__unnamed_503
> > - 5)         16 (0.0%)  d@0x6f559a0  -201240 /tmp/lto-llvm-536ab2.o
> >                .L__unnamed_503
> > + 6)     191912 (529.5%) d@0x6fc3b40  191896  /tmp/lto-llvm-ac6b26.o
> >                .L__unnamed_223
> > - 7)         24 (0.1%)  d@0x6fc3b40  -191888 /tmp/lto-llvm-536ab2.o
> >                .L__unnamed_223
> 
> I don't think I'd remove it, but if you've found local builds give better
> results, then might be worth added a log message to that effect.
> 
> lgtm

Local builds are the same (not sure why I thought otherwise), leaving as is.

[estevenson, 2017-05-10 22:31:04]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:32:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 23:34:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494455464590730,
"parent_rev": "d7631c332aae8ba4281325a4955e5a46e8b857f7", "commit_rev":
"18e1d8f1798041d5df7aaeaf50065fe93367ecc7"}

[commit-bot: I haz the power, 2017-05-10 23:34:14]

Description was changed from

==========
diagnose_bloat.py: swap --silent with --verbose.

Suppress build output by default as it makes the output harder to
follow.

Other updates:
  * Remove old references to diagnose_apk_bloat.py
  * Update Linux --cloud error message
  * Fix divide-by-zero in libsupersize/describe.py

BUG=695182, 720624
==========

to

==========
diagnose_bloat.py: swap --silent with --verbose.

Suppress build output by default as it makes the output harder to
follow.

Other updates:
  * Remove old references to diagnose_apk_bloat.py
  * Update Linux --cloud error message
  * Fix divide-by-zero in libsupersize/describe.py

BUG=695182, 720624

Review-Url: https://codereview.chromium.org/2871143004
Cr-Commit-Position: refs/heads/master@{#470747}
Committed:
https://chromium.googlesource.com/chromium/src/+/18e1d8f1798041d5df7aaeaf5006...
==========

[commit-bot: I haz the power, 2017-05-10 23:34:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/18e1d8f1798041d5df7aaeaf5006...