Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2871143003: Adding ThreadChecker statement to d'tor for remoting/base classes (Closed)

Created:
3 years, 7 months ago by joedow
Modified:
3 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding ThreadChecker statement to d'tor for remoting/base classes BUG=715633 Review-Url: https://codereview.chromium.org/2871143003 Cr-Commit-Position: refs/heads/master@{#470732} Committed: https://chromium.googlesource.com/chromium/src/+/6daaab3e7632ca92af16b8614f5783ae7fafd764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M remoting/base/buffered_socket_writer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/base/running_samples.cc View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/base/telemetry_log_writer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
joedow
PTAL! I'm chunking these changes based on directory so the first is base.
3 years, 7 months ago (2017-05-10 21:57:52 UTC) #6
Jamie
LGTM. TBH, I'm not sure it's worth splitting into multiple CLs, assuming they're all as ...
3 years, 7 months ago (2017-05-10 22:15:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871143003/1
3 years, 7 months ago (2017-05-10 22:23:48 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 22:30:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6daaab3e7632ca92af16b8614f57...

Powered by Google App Engine
This is Rietveld 408576698