Missing webcontents shouldn't block download interception

Missing webcontents shouldn't block download interception

If a download is intercepted by Android DownloadManager, we shouldn't block the download if WebContents is gone.

BUG=717077
Review-Url: https://codereview.chromium.org/2871123006
Cr-Commit-Position: refs/heads/master@{#472510}
Committed: https://chromium.googlesource.com/chromium/src/+/1706251f5a0f9955a35c5bdac59f2b45c95a2904

[qinmin, 2017-05-10 23:00:58]

qinmin@chromium.org changed reviewers:
+ dtrainor@chromium.org

[qinmin, 2017-05-10 23:00:58]

PTAL

[qinmin, 2017-05-16 18:31:49]

ping, dtrainor@, please take a look

[David Trainor- moved to gerrit, 2017-05-17 17:14:03]

lgtm

https://codereview.chromium.org/2871123006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java
(right):

https://codereview.chromium.org/2871123006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:222:
static void enqueueDownloadManagerRequest(final DownloadInfo info) {
Should this have the same name as above?

[qinmin, 2017-05-17 17:50:12]

https://codereview.chromium.org/2871123006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java
(right):

https://codereview.chromium.org/2871123006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java:222:
static void enqueueDownloadManagerRequest(final DownloadInfo info) {
On 2017/05/17 17:14:03, David Trainor-ping if over 24h wrote:
> Should this have the same name as above?

There is an issue with our JNI generator if two functions have the same name. So
I will leave this as it is now.

[qinmin, 2017-05-17 17:50:16]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:51:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:43:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495043416477900, "parent_rev":
"83325fee9ee045b846a4965e2773c3bf26bcdba0", "commit_rev":
"1706251f5a0f9955a35c5bdac59f2b45c95a2904"}

[commit-bot: I haz the power, 2017-05-17 18:43:38]

Description was changed from

==========
Missing webcontents shouldn't block download interception

If a download is intercepted by Android DownloadManager, we shouldn't block the
download if WebContents is gone.

BUG=717077
==========

to

==========
Missing webcontents shouldn't block download interception

If a download is intercepted by Android DownloadManager, we shouldn't block the
download if WebContents is gone.

BUG=717077

Review-Url: https://codereview.chromium.org/2871123006
Cr-Commit-Position: refs/heads/master@{#472510}
Committed:
https://chromium.googlesource.com/chromium/src/+/1706251f5a0f9955a35c5bdac59f...
==========

[commit-bot: I haz the power, 2017-05-17 18:43:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1706251f5a0f9955a35c5bdac59f...