Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2871123005: Fix compilation of heap compaction debug diagnostics code. (Closed)

Created:
3 years, 7 months ago by sof
Modified:
3 years, 7 months ago
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation of heap compaction debug diagnostics code. R= BUG=675877 Review-Url: https://codereview.chromium.org/2871123005 Cr-Commit-Position: refs/heads/master@{#470893} Committed: https://chromium.googlesource.com/chromium/src/+/105367830b1399896ca35b588d003c688b3f4df0

Patch Set 1 #

Patch Set 2 : revert debug settings back to disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapCompact.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapCompact.cpp View 8 chunks +13 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
sof
please take a look. (ps#1 verifies that it compiles w/ debug macros enabled.)
3 years, 7 months ago (2017-05-10 18:53:04 UTC) #5
Nico
lgtm, thanks. (I think just deleting might be better, but ¯\_(ツ)_/¯)
3 years, 7 months ago (2017-05-10 18:55:57 UTC) #8
haraken
LGTM
3 years, 7 months ago (2017-05-11 01:11:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871123005/20001
3 years, 7 months ago (2017-05-11 08:33:56 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 09:54:36 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/105367830b1399896ca35b588d00...

Powered by Google App Engine
This is Rietveld 408576698