[Headless] Have public_deps chain reflect inclusion chain

[Headless] Have public_deps chain reflect inclusion chain

Headless transitively exposes //skia, via the following chain:
//headless/lib depends on
//components/printing/browser depends on
//content/public/browser depends on
//skia

This CL updates the public_deps chain to reflect the inclusion chain
rather than having //headless/lib directly have //skia as a public_deps.
This better reflects the nature of the dependencies in question and
ensures that if e.g. //content/public/browser grows another dependency
that gets transitively exposed, dependents of //headless will properly
get that dependency.

Review-Url: https://codereview.chromium.org/2871123003
Cr-Commit-Position: refs/heads/master@{#470972}
Committed: https://chromium.googlesource.com/chromium/src/+/d55d54db60e10a5f26b6e63fa4728410ce9084f7

[blundell, 2017-05-10 10:38:03]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 10:38:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 11:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 11:34:58]

Dry run: This issue passed the CQ dry run.

[blundell, 2017-05-10 12:20:53]

blundell@chromium.org changed reviewers:
+ jzfeng@chromium.org, skyostil@chromium.org

[Sami, 2017-05-10 12:50:53]

lgtm, thanks for improving this!

[jzfeng, 2017-05-10 13:36:44]

lgtm

nit comment.

https://codereview.chromium.org/2871123003/diff/1/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2871123003/diff/1/headless/BUILD.gn#newcode356
headless/BUILD.gn:356: "//components/printing/browser",
this one can be removed?

[jzfeng, 2017-05-10 13:40:10]

Thank you very much!

[blundell, 2017-05-11 15:19:11]

https://codereview.chromium.org/2871123003/diff/1/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2871123003/diff/1/headless/BUILD.gn#newcode356
headless/BUILD.gn:356: "//components/printing/browser",
On 2017/05/10 13:36:44, jzfeng (OOO) wrote:
> this one can be removed? 

Done.

[blundell, 2017-05-11 15:19:14]

The CQ bit was checked by blundell@chromium.org

[blundell, 2017-05-11 15:19:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, jzfeng@chromium.org
Link to the patchset: https://codereview.chromium.org/2871123003/#ps20001
(title: "Response to review")

[commit-bot: I haz the power, 2017-05-11 15:19:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 16:28:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494515954986880,
"parent_rev": "bfa0f79fa5d0bb488214fb88eb832c6105591441", "commit_rev":
"d55d54db60e10a5f26b6e63fa4728410ce9084f7"}

[commit-bot: I haz the power, 2017-05-11 16:28:20]

Description was changed from

==========
[Headless] Have public_deps chain reflect inclusion chain

Headless transitively exposes //skia, via the following chain:
//headless/lib depends on
//components/printing/browser depends on
//content/public/browser depends on
//skia

This CL updates the public_deps chain to reflect the inclusion chain
rather than having //headless/lib directly have //skia as a public_deps.
This better reflects the nature of the dependencies in question and
ensures that if e.g. //content/public/browser grows another dependency
that gets transitively exposed, dependents of //headless will properly
get that dependency.
==========

to

==========
[Headless] Have public_deps chain reflect inclusion chain

Headless transitively exposes //skia, via the following chain:
//headless/lib depends on
//components/printing/browser depends on
//content/public/browser depends on
//skia

This CL updates the public_deps chain to reflect the inclusion chain
rather than having //headless/lib directly have //skia as a public_deps.
This better reflects the nature of the dependencies in question and
ensures that if e.g. //content/public/browser grows another dependency
that gets transitively exposed, dependents of //headless will properly
get that dependency.

Review-Url: https://codereview.chromium.org/2871123003
Cr-Commit-Position: refs/heads/master@{#470972}
Committed:
https://chromium.googlesource.com/chromium/src/+/d55d54db60e10a5f26b6e63fa472...
==========

[commit-bot: I haz the power, 2017-05-11 16:28:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d55d54db60e10a5f26b6e63fa472...