Don't use the manifest brand color when a PWA is in immersive fullscreen.

Don't use the manifest brand color when a PWA is in immersive fullscreen.

When in display: fullscreen, the status and navigation bars on Android
are hidden, and can be swiped in by users if desired. The bars also
appear if the on-screen keyboard is triggered. However, the bars
sometimes appear as completely transparent, which hurts their usability.

This CL explicitly sets the status bar color to black if a PWA is launched
in display: fullscreen, and ignores the brand color specified in the web
app manifest. This ensures that the status and navigation bars always
have a solid black background and do not appear as transparent. Since
PWAs that are open in display: fullscreen have the bars hidden most of
the time, having a black color does not overly affect the native fit and
feel too much.

BUG=714704, 716686
Review-Url: https://codereview.chromium.org/2871103002
Cr-Commit-Position: refs/heads/master@{#470762}
Committed: https://chromium.googlesource.com/chromium/src/+/675b4a3705f129ca9d31e22c42d9a785bc9bf29a

[dominickn, 2017-05-10 04:24:14]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 04:24:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 05:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 05:06:51]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-05-10 23:55:24]

dominickn@chromium.org changed reviewers:
+ tedchoc@chromium.org

[dominickn, 2017-05-10 23:55:24]

PTAL, thanks! I've talked this over with installability folks like owencm,
sbirch, and slightlyoff and they're happy with this compromise.

[Ted C, 2017-05-10 23:59:01]

lgtm

[dominickn, 2017-05-11 00:02:50]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-05-11 00:05:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-05-11 00:11:28]

Description was changed from

==========
Don't use the manifest brand color when a PWA is in immersive fullscreen.

When in display: fullscreen, the status and navigation bars on Android
are hidden, and can be swiped in by users if desired. The bars also
appear if the on-screen keyboard is triggered. However, the bars
sometimes appear as completely transparent, which hurts their usability.

This CL explicit sets the status bar color to black if a PWA is launched
in display: fullscreen, and ignores the brand color specified in the web
app manifest. This ensures that the status and navigation bars always
have a solid black background and do not appear as transparent. Since
PWAs that are open in display: fullscreen have the bars hidden most of
the time, having a black color does not overly affect the native fit and
feel too much.

BUG=714704,716686
==========

to

==========
Don't use the manifest brand color when a PWA is in immersive fullscreen.

When in display: fullscreen, the status and navigation bars on Android
are hidden, and can be swiped in by users if desired. The bars also
appear if the on-screen keyboard is triggered. However, the bars
sometimes appear as completely transparent, which hurts their usability.

This CL explicitly sets the status bar color to black if a PWA is launched
in display: fullscreen, and ignores the brand color specified in the web
app manifest. This ensures that the status and navigation bars always
have a solid black background and do not appear as transparent. Since
PWAs that are open in display: fullscreen have the bars hidden most of
the time, having a black color does not overly affect the native fit and
feel too much.

BUG=714704,716686
==========

[commit-bot: I haz the power, 2017-05-11 00:13:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494460970301630, "parent_rev":
"43d58ab78a76067b4cebcca44a26c290af673000", "commit_rev":
"675b4a3705f129ca9d31e22c42d9a785bc9bf29a"}

[commit-bot: I haz the power, 2017-05-11 00:13:49]

Description was changed from

==========
Don't use the manifest brand color when a PWA is in immersive fullscreen.

When in display: fullscreen, the status and navigation bars on Android
are hidden, and can be swiped in by users if desired. The bars also
appear if the on-screen keyboard is triggered. However, the bars
sometimes appear as completely transparent, which hurts their usability.

This CL explicitly sets the status bar color to black if a PWA is launched
in display: fullscreen, and ignores the brand color specified in the web
app manifest. This ensures that the status and navigation bars always
have a solid black background and do not appear as transparent. Since
PWAs that are open in display: fullscreen have the bars hidden most of
the time, having a black color does not overly affect the native fit and
feel too much.

BUG=714704,716686
==========

to

==========
Don't use the manifest brand color when a PWA is in immersive fullscreen.

When in display: fullscreen, the status and navigation bars on Android
are hidden, and can be swiped in by users if desired. The bars also
appear if the on-screen keyboard is triggered. However, the bars
sometimes appear as completely transparent, which hurts their usability.

This CL explicitly sets the status bar color to black if a PWA is launched
in display: fullscreen, and ignores the brand color specified in the web
app manifest. This ensures that the status and navigation bars always
have a solid black background and do not appear as transparent. Since
PWAs that are open in display: fullscreen have the bars hidden most of
the time, having a black color does not overly affect the native fit and
feel too much.

BUG=714704,716686

Review-Url: https://codereview.chromium.org/2871103002
Cr-Commit-Position: refs/heads/master@{#470762}
Committed:
https://chromium.googlesource.com/chromium/src/+/675b4a3705f129ca9d31e22c42d9...
==========

[commit-bot: I haz the power, 2017-05-11 00:13:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/675b4a3705f129ca9d31e22c42d9...