Enable VrShell by default on Android.

Enable VrShell by default on Android.

BUG=715612
Review-Url: https://codereview.chromium.org/2871053002
Cr-Commit-Position: refs/heads/master@{#471789}
Committed: https://chromium.googlesource.com/chromium/src/+/4f5fc1b7bd67d34a07bdeb5c69cd8ae101d65083

[amp, 2017-05-09 23:31:58]

amp@chromium.org changed reviewers:
+ ddorwin@chromium.org, jochen@chromium.org, rkaplow@chromium.org

[amp, 2017-05-09 23:31:58]

There was some discussion about whether we should enable our flag by default, or
just use finch server config to enable the flag on the platforms desired.

The number of users of the feature is likely very low and it's not easy to
stumble upon so the preference is to enable it everywhere and use the finch
experiment as a kill switch if needed.

Please advise if there is a better mechanism for accomplishing that than what is
in this change.

+jochen for content
+rkaplow for fieldtrial testing config and general finch

[amp, 2017-05-09 23:48:44]

On 2017/05/09 23:31:58, amp wrote:
> There was some discussion about whether we should enable our flag by default,
or
> just use finch server config to enable the flag on the platforms desired.
> 
> The number of users of the feature is likely very low and it's not easy to
> stumble upon so the preference is to enable it everywhere and use the finch
> experiment as a kill switch if needed.
> 
> Please advise if there is a better mechanism for accomplishing that than what
is
> in this change.
> 
> +jochen for content
> +rkaplow for fieldtrial testing config and general finch

Per some more internal discussion we have decided to stick with the finch based
launch.  Please disregard this change (but feel free to comment if you want to
make sure we are doing things the right way). :)

[amp, 2017-05-12 17:04:25]

Description was changed from

==========
Enable VrShell by default on Android.

BUG=715612
==========

to

==========
Enable VrShell by default on Android.

BUG=715612
==========

[amp, 2017-05-12 17:06:14]

PTAL.  Re-opening as after more discussion we do want to go with default enabled
and only use finch as a kill switch.

[ddorwin, 2017-05-12 17:37:59]

lgtm

[rkaplow, 2017-05-12 17:43:35]

lgtm

[amp, 2017-05-12 18:01:00]

The CQ bit was checked by amp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 18:01:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 19:51:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 19:51:21]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jochen (gone - plz use gerrit), 2017-05-15 05:47:36]

lgtm

[amp, 2017-05-15 15:13:32]

The CQ bit was checked by amp@chromium.org

[commit-bot: I haz the power, 2017-05-15 15:14:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 16:35:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494861212709820,
"parent_rev": "8e6d3357dce6196a843b7967695e16a4ae82c663", "commit_rev":
"4f5fc1b7bd67d34a07bdeb5c69cd8ae101d65083"}

[commit-bot: I haz the power, 2017-05-15 16:36:12]

Description was changed from

==========
Enable VrShell by default on Android.

BUG=715612
==========

to

==========
Enable VrShell by default on Android.

BUG=715612

Review-Url: https://codereview.chromium.org/2871053002
Cr-Commit-Position: refs/heads/master@{#471789}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f5fc1b7bd67d34a07bdeb5c69cd...
==========

[commit-bot: I haz the power, 2017-05-15 16:36:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f5fc1b7bd67d34a07bdeb5c69cd...