Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2871033002: merge some duplicated conditions in gn_all (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Wez
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M BUILD.gn View 7 chunks +6 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tfarina
Sorry for the delay. These are the ones I could see easily, there are probably ...
3 years, 7 months ago (2017-05-09 22:07:42 UTC) #1
Dirk Pranke
lgtm, thanks!
3 years, 7 months ago (2017-05-09 22:55:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871033002/1
3 years, 7 months ago (2017-05-10 02:12:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 04:14:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871033002/1
3 years, 7 months ago (2017-05-10 12:59:12 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 13:04:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/79acccf6d5f88dfe4c2b00f842c9...

Powered by Google App Engine
This is Rietveld 408576698