Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2870993002: Add Startup.BrowserMessageLoopStart.To.NonEmptyPaint2 metric. (Closed)

Created:
3 years, 7 months ago by Alexei Svitkine (slow)
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Startup.BrowserMessageLoopStart.To.NonEmptyPaint2 metric. This measures the time between Startup.BrowserMessageLoopStartTime being logged and Startup.FirstWebContents.NonEmptyPaint2 being logged. Also adds Startup.BrowserMessageLoopStart.To.MainNavigationStart. Goal is to be able to easier diagnose problems and also understand impact of improvements. For example, I plan to use this when I do more experimentation with my resource reordering change. BUG=634437 Review-Url: https://codereview.chromium.org/2870993002 Cr-Commit-Position: refs/heads/master@{#470573} Committed: https://chromium.googlesource.com/chromium/src/+/d80d9426357c72cc7d547d84196890efb999be36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M components/startup_metric_utils/browser/startup_metric_utils.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 30 (19 generated)
Alexei Svitkine (slow)
3 years, 7 months ago (2017-05-09 20:00:44 UTC) #9
gab
So many metrics! Would be nice if they could be organized as parent child relationship ...
3 years, 7 months ago (2017-05-09 20:12:53 UTC) #11
Alexei Svitkine (slow)
Agree, at some point we should clean these up. But I think we're still at ...
3 years, 7 months ago (2017-05-09 20:25:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870993002/20001
3 years, 7 months ago (2017-05-09 20:25:37 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/335506)
3 years, 7 months ago (2017-05-09 22:35:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870993002/20001
3 years, 7 months ago (2017-05-09 22:50:24 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:53:15 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870993002/20001
3 years, 7 months ago (2017-05-10 03:03:06 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/380558)
3 years, 7 months ago (2017-05-10 05:38:47 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870993002/20001
3 years, 7 months ago (2017-05-10 14:14:10 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 15:00:48 UTC) #30
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d80d9426357c72cc7d547d841968...

Powered by Google App Engine
This is Rietveld 408576698