|
|
Chromium Code Reviews|
Created:
3 years, 7 months ago by Alexei Svitkine (slow) Modified:
3 years, 7 months ago Reviewers:
gab CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Startup.BrowserMessageLoopStart.To.NonEmptyPaint2 metric.
This measures the time between Startup.BrowserMessageLoopStartTime
being logged and Startup.FirstWebContents.NonEmptyPaint2 being logged.
Also adds Startup.BrowserMessageLoopStart.To.MainNavigationStart.
Goal is to be able to easier diagnose problems and also understand impact
of improvements. For example, I plan to use this when I do more experimentation
with my resource reordering change.
BUG=634437
Review-Url: https://codereview.chromium.org/2870993002
Cr-Commit-Position: refs/heads/master@{#470573}
Committed: https://chromium.googlesource.com/chromium/src/+/d80d9426357c72cc7d547d84196890efb999be36
Patch Set 1 #
Messages
Total messages: 30 (19 generated)
The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
Description was changed from ========== Add Startup.BrowserMessageLoopStartToNonEmptyPaintTime metric. This measures the time between Startup.BrowserMessageLoopStartTime being logged and Startup.FirstWebContents.NonEmptyPaint2 being logged. BUG= ========== to ========== Add Startup.BrowserMessageLoopStart.To.NonEmptyPaint2 metric. This measures the time between Startup.BrowserMessageLoopStartTime being logged and Startup.FirstWebContents.NonEmptyPaint2 being logged. Also adds Startup.BrowserMessageLoopStart.To.MainNavigationStart. Goal is to be able to easier diagnose problems and also understand impact of improvements. For example, I plan to use this when I do more experimentation with my resource reordering change. BUG=634437 ==========
The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
asvitkine@chromium.org changed reviewers: + gab@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
So many metrics! Would be nice if they could be organized as parent child relationship so that by default we only see core metrics which can then be subdivided into diagnosis metrics... lgtm I guess though if you think these will be useful to you..
Agree, at some point we should clean these up. But I think we're still at the stage where we need more data. (As an aside, the nice thing now is that Brian added an optimization to not allocate all the buckets when a single value is logged in a histogram, so all of these should be much cheaper now.)
The CQ bit was unchecked by asvitkine@chromium.org
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494425608010460,
"parent_rev": "b0222f5f67d4edb059c7ca478a8349e12f6943de", "commit_rev":
"d80d9426357c72cc7d547d84196890efb999be36"}
Message was sent while issue was closed.
Description was changed from ========== Add Startup.BrowserMessageLoopStart.To.NonEmptyPaint2 metric. This measures the time between Startup.BrowserMessageLoopStartTime being logged and Startup.FirstWebContents.NonEmptyPaint2 being logged. Also adds Startup.BrowserMessageLoopStart.To.MainNavigationStart. Goal is to be able to easier diagnose problems and also understand impact of improvements. For example, I plan to use this when I do more experimentation with my resource reordering change. BUG=634437 ========== to ========== Add Startup.BrowserMessageLoopStart.To.NonEmptyPaint2 metric. This measures the time between Startup.BrowserMessageLoopStartTime being logged and Startup.FirstWebContents.NonEmptyPaint2 being logged. Also adds Startup.BrowserMessageLoopStart.To.MainNavigationStart. Goal is to be able to easier diagnose problems and also understand impact of improvements. For example, I plan to use this when I do more experimentation with my resource reordering change. BUG=634437 Review-Url: https://codereview.chromium.org/2870993002 Cr-Commit-Position: refs/heads/master@{#470573} Committed: https://chromium.googlesource.com/chromium/src/+/d80d9426357c72cc7d547d841968... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d80d9426357c72cc7d547d841968... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
