Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2870933002: Remove the unnecesary id_ member from the extension delegate (Closed)

Created:
3 years, 7 months ago by Miguel Garcia
Modified:
3 years, 7 months ago
Reviewers:
Peter Beverloo, dewittj
CC:
chromium-reviews, Peter Beverloo, chromium-apps-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unnecessary id_ member from the extension delegate This is a small clean up in preparation for removing the delegates when using extensions and non persistent notifications. BUG=717725 Review-Url: https://codereview.chromium.org/2870933002 Cr-Commit-Position: refs/heads/master@{#470866} Committed: https://chromium.googlesource.com/chromium/src/+/20130882054a5b215f79d01c9ff73958780ad56b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/extensions/api/notifications/notifications_api.cc View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Miguel Garcia
3 years, 7 months ago (2017-05-10 13:43:42 UTC) #6
Peter Beverloo
lgtm +dewittj for OWNERS
3 years, 7 months ago (2017-05-10 13:51:26 UTC) #10
dewittj
lgtm
3 years, 7 months ago (2017-05-10 17:13:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870933002/1
3 years, 7 months ago (2017-05-11 06:34:19 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 08:01:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20130882054a5b215f79d01c9ff7...

Powered by Google App Engine
This is Rietveld 408576698