Multi-profile flag cleanup

Multi-profile flag cleanup.

BUG=364604, 351655
TEST=existing tests
TBR=sky

[Nikita (slow), 2014-05-19 11:00:14]

This is also crbug.com/351655, reassigned to you.

[Nikita (slow), 2014-05-19 14:27:15]

lgtm

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc:16:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/crash_restore_browsertest.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/crash_restore_browsertest.cc:13: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:32:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/kiosk_browsertest.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/kiosk_browsertest.cc:41: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/login_manager_test.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/login_manager_test.cc:14: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc:18: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc:31:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc:31:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc:28:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/preferences_browsertest.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/preferences_browsertest.cc:21: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/profiles/profile_helper_browsertest.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_helper_browsertest.cc:13: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc:20: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/extension...
File
chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/networking_private/networking_private_apitest.cc:13:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/metrics/m...
File chrome/browser/metrics/metrics_log_unittest.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/metrics/m...
chrome/browser/metrics/metrics_log_unittest.cc:25: #include
"chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/notificat...
File
chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/notificat...
chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc:12:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/notificat...
File chrome/browser/notifications/message_center_settings_controller_unittest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/notificat...
chrome/browser/notifications/message_center_settings_controller_unittest.cc:13:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/ash/mu...
File
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/ash/mu...
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc:15:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/ash/mu...
File
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/ash/mu...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc:21:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/startu...
File chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/startu...
chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc:21: #if
defined(OS_CHROMEOS)
nit: can safely remove this block (both includes).

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc:16:
#include "chrome/common/chrome_switches.h"
nit: not used

https://codereview.chromium.org/287083003/diff/40001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:891: // TODO(zelidrag): Remove this one
completely in M-38+ once most profiles
What about users that will update from pre-M-37 profiles and will miss that
migration process? I assume non-existing flags should just get ignored somehow
and don't require Chrome browser process restart.

[Nikita (slow), 2014-05-19 14:27:31]

thanks for taking care of this!

[zel, 2014-05-19 18:06:27]

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
(right):

https://codereview.chromium.org/287083003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc:16:
#include "chrome/common/chrome_switches.h"
On 2014/05/19 14:27:15, Nikita Kostylev wrote:
> nit: not used

Fixed this one and all others on the same subject.

https://codereview.chromium.org/287083003/diff/40001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/287083003/diff/40001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:891: // TODO(zelidrag): Remove this one
completely in M-38+ once most profiles
On 2014/05/19 14:27:15, Nikita Kostylev wrote:
> What about users that will update from pre-M-37 profiles and will miss that
> migration process? I assume non-existing flags should just get ignored somehow
> and don't require Chrome browser process restart.

Actually, it seems that we don't have to do this type of filtering at all since
FlagsState::ConvertFlagsToSwitches()/GetSanitizedEnabledFlagsForCurrentPlatform()
takes care for this.

Removed.

[zel, 2014-05-19 18:08:39]

+sky for TBR rubber stamp

[zel, 2014-05-19 18:08:48]

The CQ bit was checked by zelidrag@chromium.org

[commit-bot: I haz the power, 2014-05-19 18:09:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zelidrag@chromium.org/287083003/80001

[commit-bot: I haz the power, 2014-05-19 20:44:06]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-19 20:48:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 20:48:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[zel, 2014-05-19 21:30:37]

The CQ bit was checked by zelidrag@chromium.org

[commit-bot: I haz the power, 2014-05-19 21:31:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zelidrag@chromium.org/287083003/80001

[commit-bot: I haz the power, 2014-05-19 21:52:31]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-19 21:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 21:55:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[zel, 2014-05-20 06:18:26]

The CQ bit was checked by zelidrag@chromium.org

[commit-bot: I haz the power, 2014-05-20 06:18:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zelidrag@chromium.org/287083003/80001

[commit-bot: I haz the power, 2014-05-20 06:35:08]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-20 06:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 06:39:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[Nikita (slow), 2014-05-20 07:47:40]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-05-20 07:47:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zelidrag@chromium.org/287083003/80001

[commit-bot: I haz the power, 2014-05-20 08:04:57]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-20 08:07:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 08:07:48]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[Nikita (slow), 2014-05-26 08:07:28]

Rebased version of this CL has been committed in
https://codereview.chromium.org/294033002/

Closing this one.