Multi-profile flag cleanup

chrome/browser/chromeos/profiles/profile_helper_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"

[Nikita (slow), 2014/05/19 14:27:15]

nit: not used

 #include "chrome/test/base/in_process_browser_test.h"
 #include "chromeos/chromeos_switches.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 namespace {
 static const char kActiveUserHash[] = "01234567890";
 } // namespace
 
 // The boolean parameter, retrieved by GetParam(), is true if testing with
 // multi-profiles enabled.
-class ProfileHelperTest : public InProcessBrowserTest,
-                          public testing::WithParamInterface<bool> {
+class ProfileHelperTest : public InProcessBrowserTest {
  public:
   ProfileHelperTest() {
   }
 
  protected:
-  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
-    if (GetParam())
-      command_line->AppendSwitch(::switches::kMultiProfiles);
-  }
-
   void ActiveUserChanged(ProfileHelper* profile_helper,
                          const std::string& hash) {
     profile_helper->ActiveUserHashChanged(hash);
   }
 };
 
-IN_PROC_BROWSER_TEST_P(ProfileHelperTest, ActiveUserProfileDir) {
+IN_PROC_BROWSER_TEST_F(ProfileHelperTest, ActiveUserProfileDir) {
   ProfileHelper profile_helper;
   ActiveUserChanged(&profile_helper, kActiveUserHash);
   base::FilePath profile_dir = profile_helper.GetActiveUserProfileDir();
   std::string expected_dir;
   expected_dir.append(chrome::kProfileDirPrefix);
   expected_dir.append(kActiveUserHash);
   EXPECT_EQ(expected_dir, profile_dir.BaseName().value());
 }
 
-IN_PROC_BROWSER_TEST_P(ProfileHelperTest,
+IN_PROC_BROWSER_TEST_F(ProfileHelperTest,
                        GetProfileDirByLegacyLoginProfileSwitch) {
   CommandLine::ForCurrentProcess()->
       AppendSwitchASCII(chromeos::switches::kLoginProfile,
                         chrome::kLegacyProfileDir);
   EXPECT_EQ(chrome::kLegacyProfileDir,
             ProfileHelper::GetProfileDirByLegacyLoginProfileSwitch().value());
   CommandLine::ForCurrentProcess()->
       AppendSwitchASCII(chromeos::switches::kLoginProfile,
                         chrome::kTestUserProfileDir);
   EXPECT_EQ(chrome::kTestUserProfileDir,
             ProfileHelper::GetProfileDirByLegacyLoginProfileSwitch().value());
   CommandLine::ForCurrentProcess()->
         AppendSwitchASCII(chromeos::switches::kLoginProfile,
                           kActiveUserHash);
   EXPECT_EQ(std::string(chrome::kProfileDirPrefix) + kActiveUserHash,
             ProfileHelper::GetProfileDirByLegacyLoginProfileSwitch().value());
 }
 
-IN_PROC_BROWSER_TEST_P(ProfileHelperTest, GetProfilePathByUserIdHash) {
+IN_PROC_BROWSER_TEST_F(ProfileHelperTest, GetProfilePathByUserIdHash) {
   ProfileHelper profile_helper;
   base::FilePath profile_path =
       profile_helper.GetProfilePathByUserIdHash(kActiveUserHash);
   base::FilePath expected_path = g_browser_process->profile_manager()->
       user_data_dir().Append(
           std::string(chrome::kProfileDirPrefix) + kActiveUserHash);
   EXPECT_EQ(expected_path, profile_path);
 }
 
-INSTANTIATE_TEST_CASE_P(ProfileHelperTestInstantiation,
-                        ProfileHelperTest,
-                        testing::Bool());
-
 }  // namespace chromeos