swarming: fix support for raw command + isolated file

swarming: fix support for raw command + isolated file

- Remove support for unnamed isolated_hash argument on the command line. It must
  now use -s or --isolated.
- Create a smoke test for --raw-cmd + --isolated
- Add check at task creation that command and extra_args cannot be both
  specified.
- Remove assert from task_runner which was unnecessary and broke this use case.
- Added relevant unit test

Warning: this is a breaking change due to the enforcement to use --isolated to
specify the isolated hash.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2870793002
Committed: https://github.com/luci/luci-py/commit/f1b353533186324cb28a51007ea2550be23f9e12

[M-A Ruel, 2017-05-09 19:04:07]

Patchset #1 (id:1) has been deleted

[M-A Ruel, 2017-05-09 20:57:37]

Patchset #1 (id:20001) has been deleted

[M-A Ruel, 2017-05-09 21:00:39]

Description was changed from

==========
local_smoke_test: add new test case

Tests that a command can be specified in the swarming task, while using an
isolated file.

No functional change.

R=iannucci@chromium.org
BUG=
==========

to

==========
swarming: fix support for raw command + isolated file

- Remove support for unnamed isolated_hash argument on the command line. It must
  now use -s or --isolated.
- Create a smoke test for --raw-cmd + --isolated
- Add check at task creation that command and extra_args cannot be both
  specified.
- Remove assert from task_runner which was unnecessary and broke this use case.
- Added relevant unit test

Warning: this is a breaking change due to the enforcement to use --isolated to
specify the isolated hash.

R=iannucci@chromium.org
BUG=
==========

[M-A Ruel, 2017-05-09 21:00:55]

Description was changed from

==========
swarming: fix support for raw command + isolated file

- Remove support for unnamed isolated_hash argument on the command line. It must
  now use -s or --isolated.
- Create a smoke test for --raw-cmd + --isolated
- Add check at task creation that command and extra_args cannot be both
  specified.
- Remove assert from task_runner which was unnecessary and broke this use case.
- Added relevant unit test

Warning: this is a breaking change due to the enforcement to use --isolated to
specify the isolated hash.

R=iannucci@chromium.org
BUG=
==========

to

==========
swarming: fix support for raw command + isolated file

- Remove support for unnamed isolated_hash argument on the command line. It must
  now use -s or --isolated.
- Create a smoke test for --raw-cmd + --isolated
- Add check at task creation that command and extra_args cannot be both
  specified.
- Remove assert from task_runner which was unnecessary and broke this use case.
- Added relevant unit test

Warning: this is a breaking change due to the enforcement to use --isolated to
specify the isolated hash.

R=iannucci@chromium.org
BUG=
==========

[M-A Ruel, 2017-05-09 21:01:16]

Now good. Both with smoke test and unit test.

[iannucci, 2017-05-09 21:40:23]

woohoo! \o/

lgtm

https://codereview.chromium.org/2870793002/diff/40001/client/swarming.py
File client/swarming.py (right):

https://codereview.chromium.org/2870793002/diff/40001/client/swarming.py#newc...
client/swarming.py:8: __version__ = '0.9.1'
maybe 1.0.0 since the CLI is changing in a backwards incompatible way?

[M-A Ruel, 2017-05-09 22:49:28]

https://codereview.chromium.org/2870793002/diff/40001/client/swarming.py
File client/swarming.py (right):

https://codereview.chromium.org/2870793002/diff/40001/client/swarming.py#newc...
client/swarming.py:8: __version__ = '0.9.1'
On 2017/05/09 21:40:23, iannucci wrote:
> maybe 1.0.0 since the CLI is changing in a backwards incompatible way?

I prefer to not jump too fast. :)

[M-A Ruel, 2017-05-09 22:49:49]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2017-05-09 22:50:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 23:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:51:27]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/360839538583ae10)

[M-A Ruel, 2017-05-10 17:08:44]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:08:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:43:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494436124682710,
"parent_rev": "aaecd12250467434995993f93f04c1ab815c2e33", "commit_rev":
"f1b353533186324cb28a51007ea2550be23f9e12"}

[commit-bot: I haz the power, 2017-05-10 17:43:27]

Description was changed from

==========
swarming: fix support for raw command + isolated file

- Remove support for unnamed isolated_hash argument on the command line. It must
  now use -s or --isolated.
- Create a smoke test for --raw-cmd + --isolated
- Add check at task creation that command and extra_args cannot be both
  specified.
- Remove assert from task_runner which was unnecessary and broke this use case.
- Added relevant unit test

Warning: this is a breaking change due to the enforcement to use --isolated to
specify the isolated hash.

R=iannucci@chromium.org
BUG=
==========

to

==========
swarming: fix support for raw command + isolated file

- Remove support for unnamed isolated_hash argument on the command line. It must
  now use -s or --isolated.
- Create a smoke test for --raw-cmd + --isolated
- Add check at task creation that command and extra_args cannot be both
  specified.
- Remove assert from task_runner which was unnecessary and broke this use case.
- Added relevant unit test

Warning: this is a breaking change due to the enforcement to use --isolated to
specify the isolated hash.

R=iannucci@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2870793002
Committed:
https://github.com/luci/luci-py/commit/f1b353533186324cb28a51007ea2550be23f9e12
==========

[commit-bot: I haz the power, 2017-05-10 17:43:28]

Committed patchset #1 (id:40001) as
https://github.com/luci/luci-py/commit/f1b353533186324cb28a51007ea2550be23f9e12