Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2870753004:
Add SwiftShader libraries to Linux installer package. (Closed)
DescriptionAdd SwiftShader libraries to Linux installer package.
BUG=719507
TBR=mmoss@chromium.org
NOTRY=true
NOPRESUBMIT=true
(cherry picked from commit 8762c915f746100704a494b9dd09075030e77906)
Review-Url: https://codereview.chromium.org/2870753004
Cr-Commit-Position: refs/branch-heads/3071@{#501}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/12037bf2488b1b3a57a622f52328f1c79ede7164
Patch Set 1 #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
mmoss@google.com changed reviewers: + mmoss@google.com
lgtm
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add SwiftShader libraries to Linux installer package. BUG=719507 (cherry picked from commit 8762c915f746100704a494b9dd09075030e77906) ========== to ========== Add SwiftShader libraries to Linux installer package. BUG=719507 TBR=mmoss@chromium.org (cherry picked from commit 8762c915f746100704a494b9dd09075030e77906) ==========
capn@chromium.org changed reviewers: + cwallez@chromium.org, mmoss@chromium.org - mmoss@google.com
On 2017/05/09 at 21:15:42, mmoss wrote: > lgtm lgtm too It seems you lgtmed from your @google.com account, you might want to take a look at crbug.com/717544 for a workaround to use your @chromium.org account. LGTMing too with the hope that this will allow the TBR= to work.
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Add SwiftShader libraries to Linux installer package. BUG=719507 TBR=mmoss@chromium.org (cherry picked from commit 8762c915f746100704a494b9dd09075030e77906) ========== to ========== Add SwiftShader libraries to Linux installer package. BUG=719507 TBR=mmoss@chromium.org NOTRY=true NOPRESUBMIT=true (cherry picked from commit 8762c915f746100704a494b9dd09075030e77906) ==========
capn@chromium.org changed reviewers: + mmoss@google.com
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494426713436540, "parent_rev":
"385235fa6b84839ade554fdfe080b7f67990a16c", "commit_rev":
"12037bf2488b1b3a57a622f52328f1c79ede7164"}
Message was sent while issue was closed.
Description was changed from ========== Add SwiftShader libraries to Linux installer package. BUG=719507 TBR=mmoss@chromium.org NOTRY=true NOPRESUBMIT=true (cherry picked from commit 8762c915f746100704a494b9dd09075030e77906) ========== to ========== Add SwiftShader libraries to Linux installer package. BUG=719507 TBR=mmoss@chromium.org NOTRY=true NOPRESUBMIT=true (cherry picked from commit 8762c915f746100704a494b9dd09075030e77906) Review-Url: https://codereview.chromium.org/2870753004 Cr-Commit-Position: refs/branch-heads/3071@{#501} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/12037bf2488b1b3a57a622f52328... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/12037bf2488b1b3a57a622f52328... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
