Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/binary_size/libsupersize/diff.py

Issue 2870743003: supersize: Add symbol.template_name, and strip <>s from symbol.name (Closed)
Patch Set: canned query Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/binary_size/libsupersize/diff.py
diff --git a/tools/binary_size/libsupersize/diff.py b/tools/binary_size/libsupersize/diff.py
index aa7705457b6c50d4717a7d98bbf205a6a7368938..4b7063c3eb59040966aa049544682c4aff821df1 100644
--- a/tools/binary_size/libsupersize/diff.py
+++ b/tools/binary_size/libsupersize/diff.py
@@ -24,7 +24,7 @@ def _SymbolKey(symbol):
"._468", "._467"
".L__unnamed_1193", ".L__unnamed_712"
"""
- name = symbol.full_name or symbol.name
+ name = symbol.full_name
clone_idx = name.find(' [clone ')
if clone_idx != -1:
name = name[:clone_idx]
@@ -45,9 +45,9 @@ def _CloneSymbol(sym, size):
Padding and aliases are not copied.
"""
return models.Symbol(
- sym.section_name, size, address=sym.address, name=sym.name,
- source_path=sym.source_path, object_path=sym.object_path,
- full_name=sym.full_name, flags=sym.flags)
+ sym.section_name, size, address=sym.address, full_name=sym.full_name,
+ template_name=sym.template_name, name=sym.name,
+ source_path=sym.source_path, object_path=sym.object_path, flags=sym.flags)
def _CloneAlias(sym, diffed_alias):
@@ -175,9 +175,7 @@ def _DiffSymbolGroups(before, after):
similar.append(models.Symbol(
section_name, padding,
name="** aggregate padding of diff'ed symbols"))
- return models.SymbolDiff(
- added, removed, similar, name=after.name, full_name=after.full_name,
- section_name=after.section_name)
+ return models.SymbolDiff(added, removed, similar)
def Diff(before, after):

Powered by Google App Engine
This is Rietveld 408576698