Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/binary_size/libsupersize/describe.py

Issue 2870743003: supersize: Add symbol.template_name, and strip <>s from symbol.name (Closed)
Patch Set: canned query Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/binary_size/libsupersize/describe.py
diff --git a/tools/binary_size/libsupersize/describe.py b/tools/binary_size/libsupersize/describe.py
index f2bc65cb18f89caad88654dccaa04136475e4f3f..e3dba0ef28d2d3512d1e7e3f118a4824c3c5aa53 100644
--- a/tools/binary_size/libsupersize/describe.py
+++ b/tools/binary_size/libsupersize/describe.py
@@ -93,7 +93,7 @@ class Describer(object):
sym.source_path, sym.object_path)
if sym.name:
yield ' flags={} name={}'.format(sym.FlagsString(), sym.name)
- if sym.full_name:
+ if sym.full_name is not sym.name:
yield ' full_name={}'.format(sym.full_name)
elif sym.full_name:
yield ' flags={} full_name={}'.format(
@@ -253,8 +253,9 @@ def DescribeSizeInfoCoverage(size_info):
expected_size = size_info.section_sizes[
models.SECTION_TO_SECTION_NAME[section]]
-
- in_section = size_info.symbols.WhereInSection(section)
+ # Use raw_symbols in case symbols contains groups.
+ in_section = models.SymbolGroup(size_info.raw_symbols).WhereInSection(
+ section)
actual_size = in_section.size
size_percent = float(actual_size) / expected_size
yield ('Section {}: has {:.1%} of {} bytes accounted for from '
@@ -269,11 +270,12 @@ def DescribeSizeInfoCoverage(size_info):
if len(star_syms):
yield ('* {} placeholders (symbols that start with **) account for '
'{} bytes ({:.1%})').format(
- len(star_syms), star_syms.pss, star_syms.pss / in_section.size)
+ len(star_syms), star_syms.size,
+ float(star_syms.size) / in_section.size)
if anonymous_syms:
yield '* {} anonymous symbols account for {} bytes ({:.1%})'.format(
len(anonymous_syms), int(anonymous_syms.pss),
- star_syms.pss / in_section.size)
+ float(star_syms.size) / in_section.size)
aliased_symbols = in_section.Filter(lambda s: s.aliases)
if section == 't':

Powered by Google App Engine
This is Rietveld 408576698