Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2870683003: [heap] Factor out marking state of array buffer tracker (Closed)

Created:
3 years, 7 months ago by Michael Lippautz
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Factor out marking state of array buffer tracker BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2870683003 Cr-Commit-Position: refs/heads/master@{#45184} Committed: https://chromium.googlesource.com/v8/v8/+/4aa5241fe984b705a605e1f33eb643319beed6dc

Patch Set 1 #

Patch Set 2 : Get MarkingState out of thin air #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M src/heap/array-buffer-tracker.h View 1 3 chunks +11 lines, -4 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M src/heap/mark-compact.cc View 1 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Michael Lippautz
ptal
3 years, 7 months ago (2017-05-09 09:25:04 UTC) #2
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-09 09:37:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870683003/20001
3 years, 7 months ago (2017-05-09 09:39:23 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 10:09:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4aa5241fe984b705a605e1f33eb643319be...

Powered by Google App Engine
This is Rietveld 408576698