Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2870673004: binutils: Add ICF alignment fix. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

binutils: Add ICF alignment fix. From the patch: "This fix keeps the section with the highest alignment when folding sections with ICF." We hit this bug when building with -Os on Linux. BUG=576197 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2870673004 Cr-Commit-Position: refs/heads/master@{#470364} Committed: https://chromium.googlesource.com/chromium/src/+/99523f7479f73ad1da22d36f34ac0ccf11670276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -2 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/binutils/build-all.sh View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/binutils/icf-align.patch View 1 chunk +126 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pcc1
3 years, 7 months ago (2017-05-09 02:47:54 UTC) #1
pcc1
Sent upload request to goma maintainers, will update once done.
3 years, 7 months ago (2017-05-09 02:50:15 UTC) #2
pcc1
Uploaded.
3 years, 7 months ago (2017-05-09 03:51:38 UTC) #4
Nico
lgtm
3 years, 7 months ago (2017-05-09 11:05:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870673004/1
3 years, 7 months ago (2017-05-09 17:08:25 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:20:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99523f7479f73ad1da22d36f34ac...

Powered by Google App Engine
This is Rietveld 408576698