ozone: Use the right thread for BinderRegistry.

ozone: Use the right thread for BinderRegistry.

In single-process mode, it is necessary to make sure that the
DeviceCursor is initialized on the gpu thread, as opposed to
the ui thread. Otherwise, we end up using gpu-thread specific
objects (e.g. |OzonePlatformGbm::pending_cursor_requests_|,
|OzonePlatformGbm::drm_thread_proxy_|) from both the gpu and
ui threads.

BUG=717257
Review-Url: https://codereview.chromium.org/2870653002
Cr-Commit-Position: refs/heads/master@{#470056}
Committed: https://chromium.googlesource.com/chromium/src/+/2fc984150a60b860103aa4d2f67d9c1686d340da

[sadrul, 2017-05-08 16:16:54]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 16:17:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:50:44]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sadrul, 2017-05-08 17:22:42]

sadrul@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2017-05-08 18:09:57]

lgtm

[sky, 2017-05-08 18:16:47]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:18:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 18:34:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494267407650450, "parent_rev":
"ebf6fbf2be685954f943768d97a0c77596cac36d", "commit_rev":
"2fc984150a60b860103aa4d2f67d9c1686d340da"}

[commit-bot: I haz the power, 2017-05-08 18:34:52]

Description was changed from

==========
ozone: Use the right thread for BinderRegistry.

In single-process mode, it is necessary to make sure that the
DeviceCursor is initialized on the gpu thread, as opposed to
the ui thread. Otherwise, we end up using gpu-thread specific
objects (e.g. |OzonePlatformGbm::pending_cursor_requests_|,
|OzonePlatformGbm::drm_thread_proxy_|) from both the gpu and
ui threads.

BUG=717257
==========

to

==========
ozone: Use the right thread for BinderRegistry.

In single-process mode, it is necessary to make sure that the
DeviceCursor is initialized on the gpu thread, as opposed to
the ui thread. Otherwise, we end up using gpu-thread specific
objects (e.g. |OzonePlatformGbm::pending_cursor_requests_|,
|OzonePlatformGbm::drm_thread_proxy_|) from both the gpu and
ui threads.

BUG=717257

Review-Url: https://codereview.chromium.org/2870653002
Cr-Commit-Position: refs/heads/master@{#470056}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fc984150a60b860103aa4d2f67d...
==========

[commit-bot: I haz the power, 2017-05-08 18:34:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fc984150a60b860103aa4d2f67d...

[varad, 2017-06-02 09:59:40]

varadgautam@gmail.com changed reviewers:
+ varadgautam@gmail.com

[varad, 2017-06-02 09:59:41]

https://codereview.chromium.org/2870653002/diff/1/ui/ozone/platform/drm/ozone...
File ui/ozone/platform/drm/ozone_platform_gbm.cc (right):

https://codereview.chromium.org/2870653002/diff/1/ui/ozone/platform/drm/ozone...
ui/ozone/platform/drm/ozone_platform_gbm.cc:213: gpu_task_runner_ =
base::ThreadTaskRunnerHandle::Get();
exo clients segfault here during ui::OzonePlatform::InitializeForGPU when run
with --use-drm. do we want a ThreadTaskRunnerHandle::IsSet() check before the
Get()?

[rjkroege, 2017-06-02 17:25:04]

On 2017/06/02 09:59:41, varad wrote:
>
https://codereview.chromium.org/2870653002/diff/1/ui/ozone/platform/drm/ozone...
> File ui/ozone/platform/drm/ozone_platform_gbm.cc (right):
> 
>
https://codereview.chromium.org/2870653002/diff/1/ui/ozone/platform/drm/ozone...
> ui/ozone/platform/drm/ozone_platform_gbm.cc:213: gpu_task_runner_ =
> base::ThreadTaskRunnerHandle::Get();
> exo clients segfault here during ui::OzonePlatform::InitializeForGPU when run
> with --use-drm. do we want a ThreadTaskRunnerHandle::IsSet() check before the
> Get()?

File a bug please?