Fix ninja build_type for Android builder.

Fix ninja build_type for Android builder.

Also added default build_type as Release to build method arguments.

BUG=373915
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270855

[shatch, 2014-05-15 22:43:52]

Thanks for jumping on this so quickly Prasad!

lgtm

https://codereview.chromium.org/287063004/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/287063004/diff/1/tools/bisect-perf-regression...
tools/bisect-perf-regression.py:683: def BuildWithVisualStudio(targets,
build_type='Release'):
Since we're repeating 'Release' all over, should that just go into a global
somewhere?

[prasadv, 2014-05-15 23:14:32]

https://codereview.chromium.org/287063004/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/287063004/diff/1/tools/bisect-perf-regression...
tools/bisect-perf-regression.py:683: def BuildWithVisualStudio(targets,
build_type='Release'):
I think, target_build_type flag is by default set to Release. Before the changes
made by rmcilroy@ default value for build_type was Release in these functions,
therefore I added default value to build_type argument just to be on safeside to
avoid future isssues.
 
On 2014/05/15 22:43:52, shatch wrote:
> Since we're repeating 'Release' all over, should that just go into a global
> somewhere?

[shatch, 2014-05-15 23:34:29]

https://codereview.chromium.org/287063004/diff/1/tools/bisect-perf-regression.py
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/287063004/diff/1/tools/bisect-perf-regression...
tools/bisect-perf-regression.py:683: def BuildWithVisualStudio(targets,
build_type='Release'):
Sorry, I was a bit unclear, more just meant maybe move all these strings to one
spot.

def BuildWithVisualStudio(targets, build_type=TARGET_RELEASE):


It's a minor thing though, feel free to ignore it, still lgtm.

On 2014/05/15 23:14:32, prasadv wrote:
> I think, target_build_type flag is by default set to Release. Before the
changes
> made by rmcilroy@ default value for build_type was Release in these functions,
> therefore I added default value to build_type argument just to be on safeside
to
> avoid future isssues.
>  
> On 2014/05/15 22:43:52, shatch wrote:
> > Since we're repeating 'Release' all over, should that just go into a global
> > somewhere?
>

[prasadv, 2014-05-15 23:35:14]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2014-05-15 23:36:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/prasadv@chromium.org/287063004/1

[commit-bot: I haz the power, 2014-05-15 23:39:00]

Change committed as 270855