Fix ninja build_type for Android builder.

tools/bisect-perf-regression.py

Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 2a921b843ce7139a655bf9a20d5afd66f7edff43..e5a615e68d332232fc042eafc00c1192568d224b 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -654,7 +654,7 @@ def SetBuildSystemDefault(build_system):
     raise RuntimeError('%s build not supported.' % build_system)
 
 
-def BuildWithMake(threads, targets, build_type):
+def BuildWithMake(threads, targets, build_type='Release'):
   cmd = ['make', 'BUILDTYPE=%s' % build_type]
 
   if threads:
@@ -667,7 +667,7 @@ def BuildWithMake(threads, targets, build_type):
   return not return_code
 
 
-def BuildWithNinja(threads, targets, build_type):
+def BuildWithNinja(threads, targets, build_type='Release'):
   cmd = ['ninja', '-C', os.path.join('out', build_type)]
 
   if threads:
@@ -680,7 +680,7 @@ def BuildWithNinja(threads, targets, build_type):
   return not return_code
 
 
-def BuildWithVisualStudio(targets, build_type):
+def BuildWithVisualStudio(targets, build_type='Release'):

[shatch, 2014/05/15 22:43:52]

Since we're repeating 'Release' all over, should that just go into a global
somewhere?

[prasadv, 2014/05/15 23:14:32]

I think, target_build_type flag is by default set to Release. Before the changes
made by rmcilroy@ default value for build_type was Release in these functions,
therefore I added default value to build_type argument just to be on safeside to
avoid future isssues.
 
On 2014/05/15 22:43:52, shatch wrote:

[shatch, 2014/05/15 23:34:29]

Sorry, I was a bit unclear, more just meant maybe move all these strings to one
spot.

def BuildWithVisualStudio(targets, build_type=TARGET_RELEASE):


It's a minor thing though, feel free to ignore it, still lgtm.

On 2014/05/15 23:14:32, prasadv wrote:

   path_to_devenv = os.path.abspath(
       os.path.join(os.environ['VS100COMNTOOLS'], '..', 'IDE', 'devenv.com'))
   path_to_sln = os.path.join(os.getcwd(), 'chrome', 'chrome.sln')
@@ -847,7 +847,8 @@ class AndroidBuilder(Builder):
 
     build_success = False
     if opts.build_preference == 'ninja':
-      build_success = BuildWithNinja(threads, self._GetTargets())
+      build_success = BuildWithNinja(
+          threads, self._GetTargets(), opts.target_build_type)
     else:
       assert False, 'No build system defined.'