Avoid importing nacl config inside gcc_toolchain.gni for non-NaCl toolchains

Avoid importing nacl config inside gcc_toolchain.gni for non-NaCl toolchains

NaCl configuration should be kept separate from the rest of the build. Also, added a comment to prevent regression.

R=brettw@chromium.org, dpranke@chromium.org,
BUG=NONE

Review-Url: https://codereview.chromium.org/2870553002
Cr-Commit-Position: refs/heads/master@{#470165}
Committed: https://chromium.googlesource.com/chromium/src/+/7f0b7f49f8d74428d8aa688576307738801689ac

[rayb, 2017-05-08 03:01:32]

The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 03:01:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 03:01:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 03:01:52]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[rayb, 2017-05-08 03:06:30]

The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 03:06:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 03:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 03:06:45]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[rayb, 2017-05-08 03:12:41]

The CQ bit was checked by rayb@ca.ibm.com to run a CQ dry run

[rayb, 2017-05-08 03:12:42]

The CQ bit was unchecked by rayb@ca.ibm.com

[rayb, 2017-05-08 04:23:17]

ptal

[Dirk Pranke, 2017-05-08 19:22:36]

lgtm

[brettw, 2017-05-08 20:40:56]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:41:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 03:49:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494276056445900, "parent_rev":
"95ee6bf2d209326f59dd26a08f53a8958c7a49e5", "commit_rev":
"7f0b7f49f8d74428d8aa688576307738801689ac"}

[commit-bot: I haz the power, 2017-05-09 03:49:12]

Description was changed from

==========
Avoid importing nacl config inside gcc_toolchain.gni for non-NaCl toolchains

NaCl configuration should be kept separate from the rest of the build. Also,
added a comment to prevent regression.

R=brettw@chromium.org, dpranke@chromium.org,
BUG=NONE
==========

to

==========
Avoid importing nacl config inside gcc_toolchain.gni for non-NaCl toolchains

NaCl configuration should be kept separate from the rest of the build. Also,
added a comment to prevent regression.

R=brettw@chromium.org, dpranke@chromium.org,
BUG=NONE

Review-Url: https://codereview.chromium.org/2870553002
Cr-Commit-Position: refs/heads/master@{#470165}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f0b7f49f8d74428d8aa68857630...
==========

[commit-bot: I haz the power, 2017-05-09 03:49:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f0b7f49f8d74428d8aa68857630...