Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2870543005: Revert "fix #27256, track type bounds for generic functions" (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "fix #27256, track type bounds for generic functions" This reverts commit b58f826976f5fdca32e20d9dec23e0cad7721d3a. BUG= Committed: https://github.com/dart-lang/sdk/commit/3a23e604e2a15f707809d748696e043acfe7a274

Patch Set 1 #

Patch Set 2 : Reverting - causing build to fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -580 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 2 chunks +49 lines, -40 lines 0 comments Download
M pkg/dev_compiler/test/browser/runtime_tests.js View 1 25 chunks +223 lines, -223 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/BenchmarkBase.js View 1 3 chunks +12 lines, -12 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/async_helper.js View 1 1 chunk +7 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/closure.js View 1 2 chunks +20 lines, -20 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/destructuring.js View 1 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/es6_modules.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/map_keys.js View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/node_modules.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/script.js View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/varargs.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 2 chunks +4 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 1 9 chunks +49 lines, -179 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D tests/language_strong/generic_function_bounds_test.dart View 1 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Alan Knight
TBR
3 years, 7 months ago (2017-05-09 19:57:54 UTC) #2
Alan Knight
3 years, 7 months ago (2017-05-09 19:58:25 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:2) manually as
3a23e604e2a15f707809d748696e043acfe7a274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698