pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart - Issue 2870543005: Revert "fix #27256, track type bounds for generic functions"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

Issue 2870543005: Revert "fix #27256, track type bounds for generic functions" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Reverting - causing build to fail Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

index 9da7da945999728a184f28531c006a079dd806dd..ca3f810efefff793e7aeace8997be7194b3755f9 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

@@ -179,10 +179,10 @@ generic(typeConstructor, [setBaseClass]) => JS(

return makeGenericType;

})()''');

-getGenericClass(type) => safeGetOwnProperty(type, _originalDeclaration);

+getGenericClass(type) =>

+ JS('', '$safeGetOwnProperty($type, $_originalDeclaration)');

-List getGenericArgs(type) =>

- JS('List', '#', safeGetOwnProperty(type, _typeArguments));

+getGenericArgs(type) => JS('', '$safeGetOwnProperty($type, $_typeArguments)');

// TODO(vsm): Collapse into one expando.

final _constructorSig = JS('', 'Symbol("sigCtor")');