Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2870533002: [Sync] Simplify sync DEPS. (Closed)

Created:
3 years, 7 months ago by skym
Modified:
3 years, 7 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Simplify sync DEPS. Added version_info dep to top level DEPS file as it was common used. Removed google_apis from driver/DEPS as top level DEPS already contained it. BUG= Review-Url: https://codereview.chromium.org/2870533002 Cr-Commit-Position: refs/heads/master@{#470365} Committed: https://chromium.googlesource.com/chromium/src/+/cca8845a40c0ed5c7ada964dfef71a80375c0395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M components/sync/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/base/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/device_info/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
skym
PTAL. jochen@ for version_info dependency, pnoland@ because this is sync code.
3 years, 7 months ago (2017-05-08 00:09:29 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-08 06:11:57 UTC) #8
Patrick Noland
lgtm
3 years, 7 months ago (2017-05-09 17:09:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870533002/1
3 years, 7 months ago (2017-05-09 17:10:35 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:24:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cca8845a40c0ed5c7ada964dfef7...

Powered by Google App Engine
This is Rietveld 408576698