|
|
Created:
3 years, 7 months ago by Ryan Hamilton Modified:
3 years, 7 months ago Reviewers:
Buck CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix QuicChromiumClientStreamTest.HeadersBeforeDelegate to actually set
the delegate after the headers arrive. Also add a test for headers and
data arriving before the delegate.
I verified that the old test was passing "by accident" by adding a
LOG(FATAL) in SetDelegate() where it runs the buffered tasks which
was not hit when running this test.
BUG=716563
Review-Url: https://codereview.chromium.org/2870483002
Cr-Commit-Position: refs/heads/master@{#470134}
Committed: https://chromium.googlesource.com/chromium/src/+/bd73b32db882801efd8e45642d2136cdccc70945
Patch Set 1 #Patch Set 2 : Cleanup #Patch Set 3 : Rebase #
Dependent Patchsets: Messages
Total messages: 31 (26 generated)
rch@chromium.org changed reviewers: + ckrasic@google.com
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix QuicChromiumClientStreamTest.HeadersBeforeDelegate to actually set the delegate after the headers arrive. Also add a test for headers and data arriving before the delegate. I verified that the old test was passing "by accident" by adding a LOG(FATAL) in SetDelegate() where it runs the buffered tasks which was not hit when running this test. BUG=716563 ========== to ========== Fix QuicChromiumClientStreamTest.HeadersBeforeDelegate to actually set the delegate after the headers arrive. Also add a test for headers and data arriving before the delegate. I verified that the old test was passing "by accident" by adding a LOG(FATAL) in SetDelegate() where it runs the buffered tasks which was not hit when running this test. BUG=716563 ==========
rch@chromium.org changed reviewers: + ckrasic@chromium.org - ckrasic@google.com
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ckrasic@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by rch@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494277774901540, "parent_rev": "b4fa34db69eca6dac8acb4b7226dbc8ca38bdbf0", "commit_rev": "da4f17c60346e79756558b88202b7712cb834539"}
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494277774901540, "parent_rev": "a912c2e3893f640aeeba93113cc9bf56996d3e12", "commit_rev": "bd73b32db882801efd8e45642d2136cdccc70945"}
Message was sent while issue was closed.
Description was changed from ========== Fix QuicChromiumClientStreamTest.HeadersBeforeDelegate to actually set the delegate after the headers arrive. Also add a test for headers and data arriving before the delegate. I verified that the old test was passing "by accident" by adding a LOG(FATAL) in SetDelegate() where it runs the buffered tasks which was not hit when running this test. BUG=716563 ========== to ========== Fix QuicChromiumClientStreamTest.HeadersBeforeDelegate to actually set the delegate after the headers arrive. Also add a test for headers and data arriving before the delegate. I verified that the old test was passing "by accident" by adding a LOG(FATAL) in SetDelegate() where it runs the buffered tasks which was not hit when running this test. BUG=716563 Review-Url: https://codereview.chromium.org/2870483002 Cr-Commit-Position: refs/heads/master@{#470134} Committed: https://chromium.googlesource.com/chromium/src/+/bd73b32db882801efd8e45642d21... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/bd73b32db882801efd8e45642d21... |