Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Issue 2870473002: Revert of Introduce ash mojo interface for lock screen action handlers (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, oshima+watch_chromium.org, kalyank, darin (slow to review), davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce ash mojo interface for lock screen action handlers (patchset #21 id:400001 of https://codereview.chromium.org/2848813002/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 469870 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAzM2YyNjdhZWMwNGNlZGZhNTEzY2VmMTg4MGU5ZGM4MWRjODM2NDgM Original issue's description: > Introduce ash mojo interface for lock screen action handlers > > This is part of support for note taking apps on lock screen. > > This is the interface that will enable ash to observe state of > apps that can/are allowed to handle actions (currently, only > "new note" action is supported) on lock screen and update it's > state accordingly. > > For example, this interface will be used for tray icon for launching > new note. The icon will be exposed only if the action handler > controller is in the state indicating that there is an app registered > for handling new note action on lock screen. > > Clicking the icon would issue a request to action handler to handle > the action (thus adding RequestHandleAction interface). > > BUG=716081 > > Review-Url: https://codereview.chromium.org/2848813002 > Cr-Commit-Position: refs/heads/master@{#469870} > Committed: https://chromium.googlesource.com/chromium/src/+/033f267aec04cedfa513cef1880e9dc81dc83648 TBR=jdufault@chromium.org,jamescook@chromium.org,xiyuan@chromium.org,tsepez@chromium.org,tbarzic@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716081 Review-Url: https://codereview.chromium.org/2870473002 Cr-Commit-Position: refs/heads/master@{#469889} Committed: https://chromium.googlesource.com/chromium/src/+/a3bc2114046e0a7af6ed582538b8331d8e1b351f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -755 lines) Patch
M ash/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/mojo_interface_factory.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M ash/mus/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M ash/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ash/public/interfaces/tray_action.mojom View 1 chunk +0 lines, -51 lines 0 comments Download
M ash/shell.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D ash/tray_action/tray_action.h View 1 chunk +0 lines, -70 lines 0 comments Download
D ash/tray_action/tray_action.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D ash/tray_action/tray_action_observer.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ash/tray_action/tray_action_unittest.cc View 1 chunk +0 lines, -226 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller.h View 2 chunks +19 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller.cc View 2 chunks +39 lines, -73 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc View 2 chunks +44 lines, -145 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_observer.h View 2 chunks +4 lines, -3 lines 0 comments Download
A chrome/browser/chromeos/lock_screen_apps/types.h View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
findit-for-me
Created Revert of Introduce ash mojo interface for lock screen action handlers
3 years, 7 months ago (2017-05-06 20:09:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870473002/1
3 years, 7 months ago (2017-05-06 22:12:36 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-06 22:12:38 UTC) #5
Avi (use Gerrit)
On 2017/05/06 22:12:38, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 7 months ago (2017-05-06 22:12:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870473002/1
3 years, 7 months ago (2017-05-06 22:13:20 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 22:14:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3bc2114046e0a7af6ed582538b8...

Powered by Google App Engine
This is Rietveld 408576698