[error] Clear external_caught_exception in Error formatting

[error] Clear external_caught_exception in Error formatting

Clearing the pending exception is not enough - if we want to swallow an
exception while currently on top of an external handler (e.g. TryCatch),
we also need to clear external_caught_exception.

BUG=chromium:719380
Review-Url: https://codereview.chromium.org/2870423002
Cr-Commit-Position: refs/heads/master@{#45247}
Committed: https://chromium.googlesource.com/v8/v8/+/f9c4fc0d204cd3f557712b255119952e41cbc4ad

[jgruber, 2017-05-10 11:35:34]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 11:35:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-10 11:43:29]

jgruber@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[jgruber, 2017-05-10 11:43:30]

Please have a look - TBH I'm not completely completely sure what the correct fix
is here. There's places all over the codebase that clear the pending exception
without setting external_has_caught = false. 

This CL only updates the spots in messages.cc related to error formatting, but
leaves remaining spots untouched.

[jgruber, 2017-05-10 11:47:23]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 11:47:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:22:18]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-05-10 14:05:35]

LGTM.

[jgruber, 2017-05-11 06:34:12]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-05-11 06:34:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 06:35:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494484452093540,
"parent_rev": "682d5369b810929d0fbd3d7704742400b0e95559", "commit_rev":
"f9c4fc0d204cd3f557712b255119952e41cbc4ad"}

[commit-bot: I haz the power, 2017-05-11 06:36:02]

Description was changed from

==========
[error] Clear external_caught_exception in Error formatting

Clearing the pending exception is not enough - if we want to swallow an
exception while currently on top of an external handler (e.g. TryCatch),
we also need to clear external_caught_exception.

BUG=chromium:719380
==========

to

==========
[error] Clear external_caught_exception in Error formatting

Clearing the pending exception is not enough - if we want to swallow an
exception while currently on top of an external handler (e.g. TryCatch),
we also need to clear external_caught_exception.

BUG=chromium:719380

Review-Url: https://codereview.chromium.org/2870423002
Cr-Commit-Position: refs/heads/master@{#45247}
Committed:
https://chromium.googlesource.com/v8/v8/+/f9c4fc0d204cd3f557712b255119952e41c...
==========

[commit-bot: I haz the power, 2017-05-11 06:36:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f9c4fc0d204cd3f557712b255119952e41c...