Detect frames from rotated devices in VideoTrackAdapter on Android.

Detect frames from rotated devices in VideoTrackAdapter on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823
Review-Url: https://codereview.chromium.org/2870413004
Cr-Commit-Position: refs/heads/master@{#472057}
Committed: https://chromium.googlesource.com/chromium/src/+/0ac21bec152a95d8edb8e759f765a512d552357c

[Guido Urdaneta, 2017-05-11 13:43:08]

Description was changed from

==========
Detect frames from rotated devices on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823
==========

to

==========
Detect frames from rotated devices on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823
==========

[Guido Urdaneta, 2017-05-11 13:43:21]

Description was changed from

==========
Detect frames from rotated devices on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823
==========

to

==========
Detect frames from rotated devices in VideoTrackAdapter on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823
==========

[Guido Urdaneta, 2017-05-11 13:57:09]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 13:57:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-05-11 14:08:11]

guidou@chromium.org changed reviewers:
+ tommi@chromium.org

[Guido Urdaneta, 2017-05-11 14:08:24]

Hi, PTAL

[commit-bot: I haz the power, 2017-05-11 15:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 15:46:51]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Guido Urdaneta, 2017-05-15 14:06:59]

friendly ping :)

[tommi (sloooow) - chröme, 2017-05-15 19:15:45]

lgtm

https://codereview.chromium.org/2870413004/diff/1/content/renderer/media/vide...
File content/renderer/media/video_track_adapter.cc (right):

https://codereview.chromium.org/2870413004/diff/1/content/renderer/media/vide...
content/renderer/media/video_track_adapter.cc:223: #if defined(OS_ANDROID)
this is the only OS_ check in this file afaict. If there's a bug for tracking
how to do this "the right way" (without relying on heuristic and the same way
across all platforms), it would be good to mention that bug here.

[Guido Urdaneta, 2017-05-16 08:43:21]

https://codereview.chromium.org/2870413004/diff/1/content/renderer/media/vide...
File content/renderer/media/video_track_adapter.cc (right):

https://codereview.chromium.org/2870413004/diff/1/content/renderer/media/vide...
content/renderer/media/video_track_adapter.cc:223: #if defined(OS_ANDROID)
On 2017/05/15 19:15:44, tommi (sloooow) - chröme wrote:
> this is the only OS_ check in this file afaict. If there's a bug for tracking
> how to do this "the right way" (without relying on heuristic and the same way
> across all platforms), it would be good to mention that bug here.

Done.

[Guido Urdaneta, 2017-05-16 08:43:27]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-05-16 08:43:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2870413004/#ps20001
(title: "address comment by tommi@")

[commit-bot: I haz the power, 2017-05-16 08:43:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 10:18:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494924207072800,
"parent_rev": "463fb9279f5099fec429c5bb23a9a783b26f1c6c", "commit_rev":
"0ac21bec152a95d8edb8e759f765a512d552357c"}

[commit-bot: I haz the power, 2017-05-16 10:19:06]

Description was changed from

==========
Detect frames from rotated devices in VideoTrackAdapter on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823
==========

to

==========
Detect frames from rotated devices in VideoTrackAdapter on Android.

On Android, when a device is rotated, frames from the camera arrive with
width and height swapped. The VideoTrackAdapter was unable to detect this
and instead cropped them incorrectly because it treated the rotated
dimension as a violation of the maximum size settings.

This CL provides a simple mechanism to detect this problem on Android.
If the frame arrives from the camera with width and height swapped from
what was expected, treat it as a valid frame that does not need to be
adjusted.

BUG=718823

Review-Url: https://codereview.chromium.org/2870413004
Cr-Commit-Position: refs/heads/master@{#472057}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ac21bec152a95d8edb8e759f765...
==========

[commit-bot: I haz the power, 2017-05-16 10:19:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ac21bec152a95d8edb8e759f765...