Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2870383002:
Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. (Closed)
|
Created:
3 years, 7 months ago by tyoshino (SeeGerritForStatus) Modified:
3 years, 7 months ago CC:
blink-reviews, chromium-reviews, haraken Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionHave sendBeacon throw for Blobs with a type that is not CORS-safelisted.
Intent to Temporarily Remove thread:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discussion
Pre-discussion happened at blink-api-owners-discuss@:
https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6C7wWviAI/discussion
BUG=490015, 720303
R=yhirano@chromium.org,mkwst@chromium.org
Review-Url: https://codereview.chromium.org/2870383002
Cr-Commit-Position: refs/heads/master@{#471268}
Committed: https://chromium.googlesource.com/chromium/src/+/234e40e94c24453189eade9c7b3f745669e9208f
Patch Set 1 : a #Patch Set 2 : Addressed mkwst's comment #Patch Set 3 : Updated exception description #Patch Set 4 : Rebase #
Messages
Total messages: 50 (35 generated)
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. BUG=490015 ========== to ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015 ========== to ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 ========== to ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. Intent to Temporarily Remove thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discus... Pre-discussion happened at blink-api-owners-discuss@: https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 ==========
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
tyoshino@chromium.org changed reviewers: + yhirano@chromium.org
lgtm
Landing considering time for baking for possible merging to beta. We could revert it easily if the I-to-R results in not ok.
Landing considering time for baking for possible merging to beta. We could revert it easily if the I-to-R results in not ok.
The CQ bit was checked by tyoshino@chromium.org
Description was changed from ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. Intent to Temporarily Remove thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discus... Pre-discussion happened at blink-api-owners-discuss@: https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 ========== to ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. Intent to Temporarily Remove thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discus... Pre-discussion happened at blink-api-owners-discuss@: https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 R=yhirano@chromium.org ==========
The CQ bit was unchecked by tyoshino@chromium.org
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mkwst@chromium.org changed reviewers: + mkwst@chromium.org
Why not flip the runtime flag from `experimental` to `stable`? That way you'd still have Finch control over the feature.
On 2017/05/11 at 07:34:06, Mike West wrote: > Why not flip the runtime flag from `experimental` to `stable`? That way you'd still have Finch control over the feature. Actually, I'm cancelling the commit. Please either change the existing runtime enabled flag to `stable`, or remove the flag entirely. This patch leaves it in place, but unused, which isn't a good state to be in.
The CQ bit was unchecked by mkwst@chromium.org
On 2017/05/11 07:43:36, Mike West wrote: > On 2017/05/11 at 07:34:06, Mike West wrote: > > Why not flip the runtime flag from `experimental` to `stable`? That way you'd > still have Finch control over the feature. > > Actually, I'm cancelling the commit. Please either change the existing runtime > enabled flag to `stable`, or remove the flag entirely. This patch leaves it in > place, but unused, which isn't a good state to be in. Oh, right. Thanks for the advice. Updated to just flip the flag.
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tyoshino@chromium.org
Updated the exception description too.
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL, mkwst.
LGTM. :)
Description was changed from ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. Intent to Temporarily Remove thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discus... Pre-discussion happened at blink-api-owners-discuss@: https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 R=yhirano@chromium.org ========== to ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. Intent to Temporarily Remove thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discus... Pre-discussion happened at blink-api-owners-discuss@: https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 R=yhirano@chromium.org,mkwst@chromium.org ==========
The CQ bit was checked by tyoshino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org, mkwst@chromium.org Link to the patchset: https://codereview.chromium.org/2870383002/#ps120001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494582558841140,
"parent_rev": "9416cfd9144a5503f449936f2e47e91c54d13235", "commit_rev":
"234e40e94c24453189eade9c7b3f745669e9208f"}
Message was sent while issue was closed.
Description was changed from ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. Intent to Temporarily Remove thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discus... Pre-discussion happened at blink-api-owners-discuss@: https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 R=yhirano@chromium.org,mkwst@chromium.org ========== to ========== Have sendBeacon throw for Blobs with a type that is not CORS-safelisted. Intent to Temporarily Remove thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/dAfYF2gauw4/discus... Pre-discussion happened at blink-api-owners-discuss@: https://groups.google.com/a/chromium.org/d/topic/blink-api-owners-discuss/3_6... BUG=490015,720303 R=yhirano@chromium.org,mkwst@chromium.org Review-Url: https://codereview.chromium.org/2870383002 Cr-Commit-Position: refs/heads/master@{#471268} Committed: https://chromium.googlesource.com/chromium/src/+/234e40e94c24453189eade9c7b3f... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:120001) as https://chromium.googlesource.com/chromium/src/+/234e40e94c24453189eade9c7b3f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
