Add parsing for RFC 5280's InhibitAnyPolicy.

Add parsing for RFC 5280's InhibitAnyPolicy.

Review-Url: https://codereview.chromium.org/2870323002
Cr-Commit-Position: refs/heads/master@{#473053}
Committed: https://chromium.googlesource.com/chromium/src/+/d312c06c18b14864b3a9e1ccb7d6b2928586c59d

[eroman, 2017-05-10 01:36:40]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:37:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-10 01:38:11]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2017-05-10 01:38:21]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:39:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:04:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mattm, 2017-05-10 20:11:32]

lgtm w/optional suggestion

https://codereview.chromium.org/2870323002/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate.h (right):

https://codereview.chromium.org/2870323002/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate.h:483: NET_EXPORT bool
ParseInhibitAnyPolicy(const der::Input& inhibit_any_policy_tlv,
same question as other CL: should these go in certificate_policies instead of
parse_certificate?

[eroman, 2017-05-15 22:44:05]

https://codereview.chromium.org/2870323002/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate.h (right):

https://codereview.chromium.org/2870323002/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate.h:483: NET_EXPORT bool
ParseInhibitAnyPolicy(const der::Input& inhibit_any_policy_tlv,
On 2017/05/10 20:11:31, mattm wrote:
> same question as other CL: should these go in certificate_policies instead of
> parse_certificate?

Done.

[mattm, 2017-05-15 23:40:58]

lgtm

https://codereview.chromium.org/2870323002/diff/60001/net/cert/internal/certi...
File net/cert/internal/certificate_policies.h (right):

https://codereview.chromium.org/2870323002/diff/60001/net/cert/internal/certi...
net/cert/internal/certificate_policies.h:61: uint8_t* out) WARN_UNUSED_RESULT;
nit: could use a more descriptive argument name than "out"

[eroman, 2017-05-15 23:43:39]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2017-05-15 23:43:49]

https://codereview.chromium.org/2870323002/diff/60001/net/cert/internal/certi...
File net/cert/internal/certificate_policies.h (right):

https://codereview.chromium.org/2870323002/diff/60001/net/cert/internal/certi...
net/cert/internal/certificate_policies.h:61: uint8_t* out) WARN_UNUSED_RESULT;
On 2017/05/15 23:40:58, mattm wrote:
> nit: could use a more descriptive argument name than "out"

Done.

[commit-bot: I haz the power, 2017-05-15 23:44:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-16 01:40:58]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2017-05-16 01:41:03]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-05-16 01:41:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2870323002/#ps80001
(title: "rename out --> num_certs")

[commit-bot: I haz the power, 2017-05-16 01:41:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:09:25]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[eroman, 2017-05-16 20:44:56]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-05-16 20:46:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 22:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:09:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2017-05-17 00:40:41]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-05-17 00:40:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2870323002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-17 00:42:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:38:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eroman, 2017-05-17 17:38:39]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:40:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 23:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:08:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eroman, 2017-05-17 23:26:08]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:27:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 02:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 02:38:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eroman, 2017-05-18 21:36:49]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2017-05-18 21:38:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 03:06:32]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495143409311240,
"parent_rev": "bd2ecbd23ad441de13ad8276a86d2ec671704fd6", "commit_rev":
"d312c06c18b14864b3a9e1ccb7d6b2928586c59d"}

[commit-bot: I haz the power, 2017-05-19 03:06:50]

Description was changed from

==========
Add parsing for RFC 5280's InhibitAnyPolicy.
==========

to

==========
Add parsing for RFC 5280's InhibitAnyPolicy.

Review-Url: https://codereview.chromium.org/2870323002
Cr-Commit-Position: refs/heads/master@{#473053}
Committed:
https://chromium.googlesource.com/chromium/src/+/d312c06c18b14864b3a9e1ccb7d6...
==========

[commit-bot: I haz the power, 2017-05-19 03:06:51]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d312c06c18b14864b3a9e1ccb7d6...