Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issue 2870303002: PDF: React to doc links on mouse up instead of mouse down. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
dsinclair
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: React to doc links on mouse up instead of mouse down. This is more consistent with the behavior for web links. BUG=720179 Review-Url: https://codereview.chromium.org/2870303002 Cr-Commit-Position: refs/heads/master@{#470582} Committed: https://chromium.googlesource.com/chromium/src/+/de3013b3e1ca504de8784c13b66f45dc52cab0ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
3 years, 7 months ago (2017-05-10 01:08:25 UTC) #2
dsinclair
lgtm
3 years, 7 months ago (2017-05-10 14:25:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870303002/1
3 years, 7 months ago (2017-05-10 14:26:05 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 15:36:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de3013b3e1ca504de8784c13b66f...

Powered by Google App Engine
This is Rietveld 408576698